Add bazel builds to PR tests #967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are under no obligation to fix the bazel build. Only people from that subcommunity should be getting notifications of breakages there and fixing it. This is consistent with LLVM's policy on this -- https://llvm.org/docs/SupportPolicy.html#peripheral-tier @asaadaldien -- can you iterate with Maks to debug why he got a notification for this? |
oh i didn't get a notif i just saw that it failed and then scrambled to fix it. good to know that we don't have to worry about it! |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* initial commit Signed-off-by: Alexandre Eichenberger <[email protected]> * one hot upgraded, more dyn cases Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> * initial commit Signed-off-by: Alexandre Eichenberger <[email protected]> * one hot upgraded, more dyn cases Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]>
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
… errors by assertion. (llvm#968) * Conversion support (llvm#956) * initial Signed-off-by: Alexandre Eichenberger <[email protected]> * works, bool is great, but unsigned create issues Signed-off-by: Alexandre Eichenberger <[email protected]> * added support to remove the UnrealizedConversionCastOp while lowering to llvm Signed-off-by: Alexandre Eichenberger <[email protected]> * last version to support some shaped type in conversion, reduce after to Integer or Float Signed-off-by: Alexandre Eichenberger <[email protected]> * converted to cast scalar only Signed-off-by: Alexandre Eichenberger <[email protected]> * added lit tests Signed-off-by: Alexandre Eichenberger <[email protected]> * update Signed-off-by: Alexandre Eichenberger <[email protected]> * initial Signed-off-by: Alexandre Eichenberger <[email protected]> * works, bool is great, but unsigned create issues Signed-off-by: Alexandre Eichenberger <[email protected]> * added support to remove the UnrealizedConversionCastOp while lowering to llvm Signed-off-by: Alexandre Eichenberger <[email protected]> * last version to support some shaped type in conversion, reduce after to Integer or Float Signed-off-by: Alexandre Eichenberger <[email protected]> * converted to cast scalar only Signed-off-by: Alexandre Eichenberger <[email protected]> * added lit tests Signed-off-by: Alexandre Eichenberger <[email protected]> * update Signed-off-by: Alexandre Eichenberger <[email protected]> * implemented cast with index, before replacing usage Signed-off-by: Alexandre Eichenberger <[email protected]> * update Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup and use of createMath constant/constantIndex/cast/castIndex Signed-off-by: Alexandre Eichenberger <[email protected]> * make sure that only explicitly unsigned are treated as unsigned; signless and indices are treated as signed Signed-off-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Add the onnx-mlir logo to the onnxai webpage (llvm#959) * Add the onnx-mlir logo to the onnxai webpage Signed-off-by: Tung D. Le <[email protected]> * Remove a dump() Signed-off-by: Tung D. Le <[email protected]> * Missing git-add the .png file Signed-off-by: Tung D. Le <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Several small improvements including adding onnx-mlir-doc to ALL target and building onnx from the submodule (llvm#957) 1. Add onnx-mlir-doc to the ALL target. This way it will be run with the default target 2. On Windows instead of installing onnx from pip, build it from source to match other CIs 3. Remove unnecessary include in Compiler Signed-off-by: Stella Stamenova <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * fix the mistake of shape in doc-example (llvm#964) Signed-off-by: david.cheng <[email protected]> Co-authored-by: david.cheng <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * install dll to bin (llvm#963) Signed-off-by: Michael Holman <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Output better error messages for file opening errors. Signed-off-by: Yasushi Negishi <[email protected]> * Fix clang-format errors Signed-off-by: Yasushi Negishi <[email protected]> * Fix build errors. Signed-off-by: Yasushi Negishi <[email protected]> * Fix a build error Signed-off-by: Yasushi Negishi <[email protected]> * Onehot update (llvm#967) * initial commit Signed-off-by: Alexandre Eichenberger <[email protected]> * one hot upgraded, more dyn cases Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> * initial commit Signed-off-by: Alexandre Eichenberger <[email protected]> * one hot upgraded, more dyn cases Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> * cleanup Signed-off-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * We currently run a few test sets, e.g., check-onnx-backend, (llvm#958) check-onnx-backend-dynamic, etc., in serial. While we do parallelize within each test set, we don't get much benefit from it. Because within each test set, most of the time was spent on one or two long running tests. While waiting for these long running tests, we could have started the other test sets. This patch parallelizes across tests sets by starting them all at once so the long running tests from different test sets can run in parallel. CompilerLib tests are disabled because a bug has been uncovered that it was actually still using onnx-mlir instead of CompilerLibTest to compile the models. Fix the bug to use CompilerLibTest and it fails to compile the models. Use CTEST_PARALLEL_LEVEL for numerical tests to be compatible with Windows CI Signed-off-by: Gong Su <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Use ninja as a build system (llvm#946) Signed-off-by: mshr-h <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Added documentation on using DEBUG according to LLVM (llvm#970) * added documentation on using DEBUG according to LLVM Signed-off-by: Alexandre Eichenberger <[email protected]> * removed errand printf for debugging Signed-off-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * CategoryMapper: shape inference support. (llvm#971) Signed-off-by: Ettore Tiotto <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Updating docs to move into the right place (llvm#972) * Updating docs to move into the right place Signed-off-by: Alexandre Eichenberger <[email protected]> * add link Signed-off-by: Alexandre Eichenberger <[email protected]> * add links Signed-off-by: Alexandre Eichenberger <[email protected]> * add links Signed-off-by: Alexandre Eichenberger <[email protected]> * respond to comments on MLIR.cmake Signed-off-by: Alexandre Eichenberger <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Fix EnableMemoryPool to account for 'memref.cast' operation. (llvm#966) Signed-off-by: Ettore Tiotto <[email protected]> Signed-off-by: Yasushi Negishi <[email protected]> * Fix typo. Signed-off-by: Yasushi Negishi <[email protected]> * Revert "Fix typo." This reverts commit f2934faee463557ebc2adb6aca5b9521f5064f12. Signed-off-by: Yasushi Negishi <[email protected]> * Fix typo Signed-off-by: Yasushi Negishi <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Tung D. Le <[email protected]> Co-authored-by: Stella Stamenova <[email protected]> Co-authored-by: DavidChan <[email protected]> Co-authored-by: david.cheng <[email protected]> Co-authored-by: Michael Holman <[email protected]> Co-authored-by: gongsu832 <[email protected]> Co-authored-by: Masahiro Hiramori <[email protected]> Co-authored-by: Ettore Tiotto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a "Lemony Snicket's A Series of Unfortunate Events" type move, I merged #958 and then had to immediately submit #966 as a patch because it broke bazel build, which slipped past me because it wasn't in the tests. Not sure what your guys budget is for GHA/CI but maybe bazel build should be part of the PR set too?