Enter Full Screen menu line repeated #566
Milestone
Comments
|
I have seen this issue on High Sierra 10.13.1 as well: |
|
Same for me in OSX 10.13.1, @isaki-x and still seems to be broken in newer MacVim versions too 🙁 (see below for complete version and build info). Does anyone have a version installed where this did not occur? If so, perhaps we can use git's |
|
Does it still an issue? I can't reproduce it |
|
This happened to me relatively recently on 10.14.4 (I just recently upgraded to 10.14.5; I'll if I can make it happen again). |
|
I have not been able to reproduce on 10.14.5 with MacVim 8.1.950 (155). |
|
I just reproduced it.
|
|
@isaki You're lucky! Could you share any way to reproduce it all the time? |
|
Actually, I just figured that out a few minutes ago when I noticed it again and realized I had just double opened a file a few times (I had a find command opening some files for me, some of which were already open). However, testing now, I've come up with an even simpler method. I'm using gvim on the command line (which is just Do not not quit it. It doesn't have to be a real file. Just every time you get the warning hit abort. The first time nothing bad happens. Do it again. And again. You will get (n - 1) Enter Full Screen entries where n is the number of aborts.
|
|
@isaki Wow! this magic really works! I'll try to debug it! |
ychin
added a commit
to ychin/macvim
that referenced
this issue
Sep 18, 2020
Previously MacVim would see a lot of duplicate window menu items like "Enter Full Screen" or "Tile Window to Left of Screen" when the user toggles between two windows. This is because the `setWindowsMenu:` call was injecting these items, but AppKit isn't smart enough to de-duplicate them (unlike the window list at the bottom). Just fix this by making a copy of the main menu before passing it in. This way every time we try to set a main menu (which happens whenever we jump among Vim windows as each Vim can have different menu items), it will be set with a fresh one that doesn't have the injected menu items in it. Also, set NSFullScreenMenuItemEverywhere to prevent AppKit from injecting "Enter Full Screen" items. MacVim already has similar menu items to handle that. Also, remove old private API call to `setAppleMenu:`. As far as I could tell this is not useful anymore in recent macOS versions and that line of code was written in 2008. Fix macvim-dev#566, Fix macvim-dev#992
ychin
added a commit
to ychin/macvim
that referenced
this issue
Sep 20, 2020
Previously MacVim would see a lot of duplicate window menu items like "Enter Full Screen" or "Tile Window to Left of Screen" when the user toggles between two windows. This is because the `setWindowsMenu:` call was injecting these items, but AppKit isn't smart enough to de-duplicate them (unlike the window list at the bottom). Just fix this by making a copy of the main menu before passing it in. This way every time we try to set a main menu (which happens whenever we jump among Vim windows as each Vim can have different menu items), it will be set with a fresh one that doesn't have the injected menu items in it. - This also requires adding a refresh functionality because adding/removing items to the original menu no longer get automatically reflected to the app since it only knows about the copied version. Also, set NSFullScreenMenuItemEverywhere to prevent AppKit from injecting "Enter Full Screen" items. MacVim already has similar menu items to handle that. Also, remove old private API call to `setAppleMenu:`. As far as I could tell this is not useful anymore in recent macOS versions and that line of code was written in 2008. Fix macvim-dev#566, Fix macvim-dev#992
ychin
added a commit
that referenced
this issue
Sep 21, 2020
Updated to Vim 8.2.1719. Features ==================== Touch Bar improvements -------------------- Touch Bar now supports submenus, and allows mixed icon/text displays using `tmenu`. When in edit modes (e.g. insert), it will also display an emoji picker as well. See `:help touchbar` for documentation. #1084 Fixes ==================== - Window menu no longer shows duplicate "Enter Full Screen" or "Tile Window to Left of Screen" entries whenever the user switches among different MacVim windows. #566 #992 - Fix issue where going to full screen mode when titlebar appearance is set to "hidden" would result in lost focus of the window. #1078 - The password dialog box when using `:!sudo` or other commands that require password entry (`macvim-askpass`) will no longer focus on Finder, and will keep the focus on MacVim. #1091 - Fix minor wrong tooltip in the "Appearance" preference pane. #1087 - "General" preference pane will now be correctly sized when Sparkle updater is disabled (e.g. Homebrew builds). #1089 - Misc issues were fixed by Vim upstream, e.g. `vimgrep` causing a crash, and odd behaviors with using Shift-O on the first line. #1082 #1083 Compatibility ==================== Requires macOS 10.9 or above. Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.8 - Ruby 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
not really sure how to reproduce it, i just notice once in a while when i want to see the window list under the
Windowmenu. maybe others have more details.The text was updated successfully, but these errors were encountered: