Properly size General pane when DISABLE_SPARKLE=1 #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Merging. |
ychin
added a commit
that referenced
this pull request
Sep 21, 2020
Updated to Vim 8.2.1719. Features ==================== Touch Bar improvements -------------------- Touch Bar now supports submenus, and allows mixed icon/text displays using `tmenu`. When in edit modes (e.g. insert), it will also display an emoji picker as well. See `:help touchbar` for documentation. #1084 Fixes ==================== - Window menu no longer shows duplicate "Enter Full Screen" or "Tile Window to Left of Screen" entries whenever the user switches among different MacVim windows. #566 #992 - Fix issue where going to full screen mode when titlebar appearance is set to "hidden" would result in lost focus of the window. #1078 - The password dialog box when using `:!sudo` or other commands that require password entry (`macvim-askpass`) will no longer focus on Finder, and will keep the focus on MacVim. #1091 - Fix minor wrong tooltip in the "Appearance" preference pane. #1087 - "General" preference pane will now be correctly sized when Sparkle updater is disabled (e.g. Homebrew builds). #1089 - Misc issues were fixed by Vim upstream, e.g. `vimgrep` causing a crash, and odd behaviors with using Shift-O on the first line. #1082 #1083 Compatibility ==================== Requires macOS 10.9 or above. Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.8 - Ruby 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you have DISABLE_SPARKLE set, the Sparkle options will be hidden in the General preference panel. This is good, but it leaves a blank space in the panel where the options would have shown. This pull request hides the Sparkle options as before, but also resizes the panel so it is the correct size for the displayed options.