Skip to content

MacVim auto-updated while only checking is enabled #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eirnym opened this issue Dec 9, 2018 · 4 comments
Closed

MacVim auto-updated while only checking is enabled #808

eirnym opened this issue Dec 9, 2018 · 4 comments
Labels
Updater Issues related to Sparkle updater
Milestone
snapshot-153

Comments

@eirnym
Copy link
Contributor

eirnym commented Dec 9, 2018

This happened first time with release 152. Before it checked updates, but not updated. Please, fix it.
@ychin
Copy link
Member

ychin commented Dec 10, 2018 •
edited
Loading

@eirnym Are you sure you didn't accidentally check the checkbox that says "Automatically download and install updates in the future"? There were no changes made to the updater (Sparkle) AFAIK.

You can check by typing defaults read org.vim.MacVim SUAutomaticallyUpdate in the terminal. If it does say YES, and you want to remove it, type defaults delete org.vim.MacVim SUAutomaticallyUpdate in the terminal.

@eirnym
Copy link
Contributor Author

eirnym commented Dec 10, 2018

@ychin yes, I'm sure about this as I've never seen it and the previous update was a while ago. But I have this option set.

Could you expose it to settings to make it controllable at any time?

@ychin ychin added the Updater Issues related to Sparkle updater label Dec 12, 2018
@ychin ychin added this to the snapshot-153 milestone Dec 12, 2018
@ychin
Copy link
Member

ychin commented Dec 12, 2018

I'll expose it so the user will see it in the preference pane. I agree it's annoying that there's no user-visible way to undo the "always downloading updates in the background automatically" checkbox that only shows up in the update dialog box. (Since that dialog box doesn't show up when auto-update is enabled).

ychin added a commit to ychin/macvim that referenced this issue Dec 12, 2018
@ychin
Expose "automatically install updates" option in preference pane
03e13e7 
Currently the updater (Sparkle) supports an option to automatically
download and install updates in the background. The only user-visible
way to turn it on/off is by checking the checkbox in the new update
dialog box but that dialog box only shows up if auto-update is off,
meaning that there's no way to undo setting that setting. Fix this by
exposing the setting in user preference panel.

Also, previously auto-update would even still keep on working even if
"check for updates" is off, since it has precedence. Make the preference
pane un-check auto-update if "check for updates" is turned off.

Fix macvim-dev#808
@ychin ychin mentioned this issue Dec 12, 2018
Merged
@eirnym
Copy link
Contributor Author

eirnym commented Dec 28, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Updater Issues related to Sparkle updater
Projects
None yet
Milestone
snapshot-153
Development

No branches or pull requests
2 participants
@eirnym @ychin