Expose "automatically install updates" option in preference pane #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the updater (Sparkle) supports an option to automatically download and install updates in the background. The only user-visible way to turn it on/off is by checking the checkbox in the new update dialog box but that dialog box only shows up if auto-update is off, meaning that there's no way to undo setting that setting. Fix this by exposing the setting in user preference panel. Also, previously auto-update would even still keep on working even if "check for updates" is off, since it has precedence. Make the preference pane un-check auto-update if "check for updates" is turned off. Fix macvim-dev#808
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Dec 13, 2018
Vim patch 8.1.577 Targets macOS 10.8+ Features: - The option to automatically download and install updates is now exposed in the preference panel. This gives you a way to uncheck it, as previously there was no user-visible way to do so once it's checked. macvim-dev#816 Fixes: - Title bar is no longer transparent in 10.12 Sierra macvim-dev#805 - Fixed 'transparency' setting not working properly in Mojave macvim-dev#805 - Fixed setting 'fullscreen' in vimrc leading to black screen in 10.14 Mojave if non-native fullscreen is used macvim-dev#811 - Fixed showing all black if MMUseCGLayerAlways is set in 10.14 Mojave macvim-dev#811 - Fixed misconfigured Python paths in default vimrc macvim-dev#812 Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the updater (Sparkle) supports an option to automatically download and install updates in the background. The only user-visible way to turn it on/off is by checking the checkbox in the new update dialog box but that dialog box only shows up if auto-update is off, meaning that there's no way to undo setting that setting. Fix this by exposing the setting in user preference panel.
Also, previously auto-update would even still keep on working even if "check for updates" is off, since it has precedence. Make the preference pane un-check auto-update if "check for updates" is turned off.
Fix #808