New Window/Drag-Drop currently open file fails #913
Milestone
Comments
|
I have macOS Mojave Version 10.14.6 (18G48f) the same workflow makes the second window unusable, but if close the opened file and/or open, it could be opened again. Looks like dialog window should be shown, but it either invisible or hidden by a window |
|
Thanks for confirmation. I agree with you situation analysis. Instead of expected Open Read-only ... dialog just showing an unusable window.
…----- Original Message -----
From: "Arseny Nasokin" <[email protected]>
To: "macvim-dev/macvim" <[email protected]>
Cc: "Paulv445" <[email protected]>, "Author" <[email protected]>
Sent: Monday, June 17, 2019 2:13:51 PM
Subject: Re: [macvim-dev/macvim] New Window/Drag-Drop currently open file fails (#913)
I have macOS Mojave Version 10.14.6 (18G48f)
the same workflow makes the second window unusable, but if close the opened file and/or open, it could be opened again. Looks like dialog window should be shown, but it either invisible or hidden by a window
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub , or mute the thread .
|
|
I can reproduce this. This is happening due to #895, and only happens when swap files are enabled. This should be fixed next release. |
ychin
added a commit
to ychin/macvim
that referenced
this issue
Jul 7, 2019
MMBackend's `handleOpenWithArguments` previously set a "flushDisabled" flag to disable all flushing during handling the files. This was unsafe, because under the new code that handles editing immediately (instead of building a deferred set of Ex commands) MacVim tries to immediately pop up a dialog box but that message doesn't get properly flushed because it's disabled. Just remove the setting of that disabled flag as it doesn't seem like it's gaining anything. If we want to have a way to disable flushing for performance reasons in the future , we should make sure the "force" flag in flushQueue: actually gets respected and used properly (only when we want to force it). Right now the "force" flag isn't actually used. Also, make sure the dialog handling code handles the "no GUI resize" resize message (which gets set when we have `guioptions+=k`) as well and don't drop the message. Otherwise if drag-and-drop opens a new tab (since there are multiple files dropped) and the user has guioptions+=k, it won't get redrawn properly because the SetTextDimensionsNoResizeWindowMsgID message would get dropped. It's unfortunate it's a hardcoded hack like this and this should be revisited in the future. Fix macvim-dev#913
ychin
added a commit
to ychin/macvim
that referenced
this issue
Jul 21, 2019
Vim patch 8.1.1722 Features: - Add 'MMDisableLaunchAnimation' option to disable the opening animation of MacVim Windows. macvim-dev#915 - Make 'MMTitlebarAppearsTransparent' work in pre-Mojave macOS versions. macvim-dev#917 Fixes: - Fix issue where MacVim would freeze when opening a file already opened in another MacVim window when swap files are enabled. macvim-dev#913 - Menu items with name starting with ']' now properly get hidden in the main menu bar (see `:help hidden-menus`). macvim-dev#853 Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
ychin
added a commit
that referenced
this issue
Jul 28, 2019
Vim patch 8.1.1722 Features: - Add 'MMDisableLaunchAnimation' option to disable the opening animation of MacVim Windows. #915 - Make 'MMTitlebarAppearsTransparent' work in pre-Mojave macOS versions. #917 Fixes: - Fix issue where MacVim would freeze when opening a file already opened in another MacVim window when swap files are enabled. #913 - Menu items with name starting with ']' now properly get hidden in the main menu bar (see `:help hidden-menus`). #853 Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
|
Confirmed -- Custom Version 8.1.1722 (157) resolves this issue -- Thanks, Yee Cheng Chin . Paul
…----- Original Message -----
From: "Yee Cheng Chin" <[email protected]>
To: "macvim-dev/macvim" <[email protected]>
Cc: "Paulv445" <[email protected]>, "Author" <[email protected]>
Sent: Sunday, July 7, 2019 3:11:36 AM
Subject: Re: [macvim-dev/macvim] New Window/Drag-Drop currently open file fails (#913)
Closed #913 via #919 .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub , or mute the thread .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Custom Version 8.1.1517 (156)
macOX Mojave Version 10.14.5 (18F132)
File opened by drag-drop to MacVim App.
MacVim/right-mouse, New Window
Drag-Drop same file to the new window.
Until this release it opened read only.
With this release hangs, with MacVim quit required to kill window.
The text was updated successfully, but these errors were encountered: