Make MMTitlebarAppearsTransparent option work on pre-Mojave #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the special path to make tranparent titlebars work on pre-Mojave builds as well. It's annoying we have to two maintain separate code paths for how windows / titlebars work but this wasn't too hard to add. We just need to make sure to to set the background color on the window *only* when we have transparent titlebar set. Otherwise we don't want to do it because of weird interactions with textured window flag. This addresses comments made in macvim-dev#888.
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Jul 21, 2019
Vim patch 8.1.1722 Features: - Add 'MMDisableLaunchAnimation' option to disable the opening animation of MacVim Windows. macvim-dev#915 - Make 'MMTitlebarAppearsTransparent' work in pre-Mojave macOS versions. macvim-dev#917 Fixes: - Fix issue where MacVim would freeze when opening a file already opened in another MacVim window when swap files are enabled. macvim-dev#913 - Menu items with name starting with ']' now properly get hidden in the main menu bar (see `:help hidden-menus`). macvim-dev#853 Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
ychin
added a commit
that referenced
this pull request
Jul 28, 2019
Vim patch 8.1.1722 Features: - Add 'MMDisableLaunchAnimation' option to disable the opening animation of MacVim Windows. #915 - Make 'MMTitlebarAppearsTransparent' work in pre-Mojave macOS versions. #917 Fixes: - Fix issue where MacVim would freeze when opening a file already opened in another MacVim window when swap files are enabled. #913 - Menu items with name starting with ']' now properly get hidden in the main menu bar (see `:help hidden-menus`). #853 Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the special path to make tranparent titlebars work on pre-Mojave builds as well. It's annoying we have to two maintain separate code paths for how windows / titlebars work but this wasn't too hard to add. We just need to make sure to to set the background color on the window only when we have transparent titlebar set. Otherwise we don't want to do it because of weird interactions with textured window flag.
This addresses comments made in #888.