Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On GUI, timer callback can be delayed when the callback is called from job/channel callback.
Repro steps
sample.vim
Start GUI MacVim:
mvim --clean -g
and do:
The message "elapsed: ..." does not show until any user-input (key, mouse, ..) given.
That is,
TimerCb
is delayed.Cause
Timer callback does not execute in
[MMBackend waitForInput]
.Thus, when a timer is created in
parse_queued_messaged()
ingui_mch_wait_for_chars()
, the timer is ignored while waiting for input.Solution
did_add_timer
afterparse_queued_messaged()
ingui_mch_wait_for_chars()
.