Fix MMShareFindPboard and Cmd-E/Cmd-G #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMShareFindPboard is supposed to prevent MacVim from updating the system find pasteboard when searching, but the previous behavior was that it would only set the Vim-specific format to the find pasteboard so you could still share search patterns across Vim windows but it has the effect of clearing the global find pasteboard. Just fix that by making MacVim not touch the system find pasteboard at all when MMShareFindPboard is set to NO to respect user's wish. Cmd-G will still use the system find pasteboard to make it easy to search in another macOS program and jump to Vim. The user can always use `n` instead if that's not desired. Also update docs to make this clear, and rename all "OS X" to "macOS" to keep up with the times. Close macvim-dev#773
Cmd-E (Edit -> Use Selection for Find") in most macOS apps follow the convention that it shares to the system Find Pasteboard, while Cmd-G uses the Find Pasteboard to find the next item. Make Cmd-E always do that even if MMShareFindPboard is set to NO. This way, normal searches in Vim wouldn't pollute the system find pasteboard, but could still have a way to share to it by using this action.
|
I've just built using this PR and it appears to work as advertised. I'll keep playing with it. As an added bonus, it appears to have fixed bug #752! |
|
@chdiza That's good to know! I didn't realize this would fix that bug but it makes sense looking at the code, as previously it was registering the string clipboard but not providing content for it, so maybe it led to some bad interactions across the difference programs. |
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Dec 5, 2018
Vim patch 8.1.560
Targets macOS 10.8+
Features:
- macOS Mojave (10.14) is now supported.
- MacVim's UI now works with Dark Mode.
- Fixed broken rendering and flickering under Mojave when using the
default Core Text renderer. macvim-dev#757
- guioption 'k' is supported again. macvim-dev#731
- This option prevents window from resizing when UI elements such as
toolbars or tabs show or hide themselves.
Fixes:
- Fixed misc fullscreen and window resizing bugs and artifacts macvim-dev#745
- Dragging tabs to reorder now works properly macvim-dev#789
- Fixed timer callback handling in GUI macvim-dev#749
- Fixed native tabs (10.12+) interring with Vim tabs macvim-dev#788
- Fixed Japanese IME Ctrl-U/Ctrl-O handling macvim-dev#742
- Fixed MMShareFindPboard and Cmd-E/Cmd-G interactions macvim-dev#780
- Better handling of guifontwide font size macvim-dev#737
- Better python discovery in default vimrc macvim-dev#739
Known Issues:
- Scrolling performance is slightly worse under Mojave macvim-dev#796
Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.5
ychin
added a commit
that referenced
this pull request
Dec 5, 2018
Vim patch 8.1.560
Targets macOS 10.8+
Features:
- macOS Mojave (10.14) is now supported.
- MacVim's UI now works with Dark Mode.
- Fixed broken rendering and flickering under Mojave when using the
default Core Text renderer. #757
- guioption 'k' is supported again. #731
- This option prevents window from resizing when UI elements such as
toolbars or tabs show or hide themselves.
Fixes:
- Fixed misc fullscreen and window resizing bugs and artifacts #745
- Dragging tabs to reorder now works properly #789
- Fixed timer callback handling in GUI #749
- Fixed native tabs (10.12+) interring with Vim tabs #788
- Fixed Japanese IME Ctrl-U/Ctrl-O handling #742
- Fixed MMShareFindPboard and Cmd-E/Cmd-G interactions #780
- Better handling of guifontwide font size #737
- Better python discovery in default vimrc #739
Known Issues:
- Scrolling performance is slightly worse under Mojave #796
Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
MMShareFindPboardnot working properly.MMShareFindPboardis supposed to prevent MacVim from updating the system find pasteboard when searching, but the previous behavior was that it would only set the Vim-specific format to the find pasteboard so you could still share search patterns across Vim windows but it has the effect of clearing the global find pasteboard. Just fix that by making MacVim not touch the system find pasteboard at all whenMMShareFindPboardis set to NO to respect user's setting.Also, make Cmd-E/Cmd-G always use the OS find pasteboard even if
MMShareFindPboardis set toNO. This keeps the behavior consistent with how other macOS apps work and a way for the user to still access it even with the setting off. One can always still usenor other normal Vim search commands to search without using the system find pasteboard.Also update docs to make this clear, and rename all "OS X" to "macOS" to keep up with the times.
Close #773
Edit: This also Close #752