Skip to content

Make MMTitlebarAppearsTransparent option work on pre-Mojave #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Make MMTitlebarAppearsTransparent option work on pre-Mojave #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/MacVim/MMWindowController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,26 @@ - (void)setDefaultColorsBackground:(NSColor *)back foreground:(NSColor *)fore
}
}
}
else
#endif
{
// 10.13 or below. As noted above, the window flag
// NSWindowStyleMaskTexturedBackground doesn't play well with window color,
// but if we are toggling the titlebar transparent option, we need to set
// the window background color in order the title bar to be tinted correctly.
if ([[NSUserDefaults standardUserDefaults]
boolForKey:MMTitlebarAppearsTransparentKey]) {
if ([back alphaComponent] != 0) {
[decoratedWindow setBackgroundColor:back];
} else {
// See above HACK for more details. Basically we cannot set a
// color with 0 alpha or the window manager will give it a
// different treatment.
NSColor *clearColor = [back colorWithAlphaComponent:0.001];
[decoratedWindow setBackgroundColor:clearColor];
}
}
}

[vimView setDefaultColorsBackground:back foreground:fore];
}
Expand Down