fix(examples/everything): add WithBaseURL #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request updates the SSE server initialization by adding a new configuration parameter. The change modifies the instantiation of the SSE server in the main function to include a base URL option. In tandem, the Changes
Possibly related PRs
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/everything/main.go (1)
424-424: Base URL parameter added correctlyThe change properly adds the base URL configuration to the SSE server creation, which aligns with the PR's objective of adding this missing parameter. The base URL value "http://localhost:8080" corresponds to the port used in the
Startmethod call on line 426.Consider extracting the port/host values to a variable to avoid repetition and ensure consistency:
- sseServer := server.NewSSEServer(mcpServer, server.WithBaseURL("http://localhost:8080")) - log.Printf("SSE server listening on :8080") - if err := sseServer.Start(":8080"); err != nil { + const serverAddr = ":8080" + baseURL := fmt.Sprintf("http://localhost%s", serverAddr) + sseServer := server.NewSSEServer(mcpServer, server.WithBaseURL(baseURL)) + log.Printf("SSE server listening on %s", serverAddr) + if err := sseServer.Start(serverAddr); err != nil {
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing baseURL parameter with the Options function
thanks for this great project!
Summary by CodeRabbit