Skip to content

SVG output: replace black with currentColor #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pkra opened this issue Jan 9, 2015 · 4 comments
Closed

SVG output: replace black with currentColor #1002

pkra opened this issue Jan 9, 2015 · 4 comments
Assignees
@pkra
Labels
Feature Request Fixed Test Available v2.5
Milestone
MathJax v2.5

Comments

@pkra
Copy link
Contributor

pkra commented Jan 9, 2015

Could the SVG output set stroke and fill to currentColor? That would allow the SVG output to inherit text color.

I was experimenting with the SVG output and came up with http://codepen.io/pkra/pen/emgeyJ. Here are some cross-platform screenshots.

It seems to be a one-liner at https://github.com/mathjax/MathJax/blob/master/unpacked/jax/output/SVG/jax.js#L2000 ?

What do you think, @dpvc?
dpvc added a commit to dpvc/MathJax that referenced this issue Jan 11, 2015
@dpvc
Use currentColor rather than black for SVG output. Resolves issue mat…
a2c3b7c 
…hjax#1002.
@dpvc
Copy link
Member

dpvc commented Jan 11, 2015

Makes sense. I wasn't aware of this setting when the SVG output was written (it was my first use of SVG). I have made the change in the issue1002 branch of my fork of MathJax.

@dpvc dpvc added this to the MathJax 2.5 milestone Jan 11, 2015
dpvc added a commit to dpvc/MathJax that referenced this issue Jan 12, 2015
@dpvc
Merge branch 'issue1002' into develop. Issue mathjax#1002.
0182094
@dpvc
Copy link
Member

dpvc commented Jan 12, 2015

=> Merged

@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Jan 12, 2015
@dpvc dpvc closed this as completed Jan 12, 2015
@pkra
Copy link
Contributor Author

pkra commented Jan 12, 2015

Yay. Awesome. Will come up with a test.

@pkra pkra self-assigned this Jan 12, 2015
@dpvc dpvc mentioned this issue Jan 13, 2015
Closed
@pkra pkra mentioned this issue Jan 20, 2015
Closed
pkra added a commit to mathjax/MathJax-test that referenced this issue Jan 20, 2015
@pkra
add test for mathjax/MathJax#1002 test SVG output inheriting currentC…
ff754bd 
…olor
@pkra pkra mentioned this issue Jan 20, 2015
Merged
dpvc added a commit to mathjax/MathJax-test that referenced this issue Jan 20, 2015
@dpvc
Merge pull request #8 from mathjax/issue1002
979059a 
mathjax/MathJax#1002 -- test SVG output inheriting currentColor
@dpvc
Copy link
Member

dpvc commented Jan 20, 2015

==> In Testsuite

MathMLToDisplay/General/Colors/issue1002.html

@dpvc dpvc added Fixed v2.5 and removed Merged Merged into develop branch labels Jan 30, 2015
@pkra pkra mentioned this issue Aug 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkra pkra

Labels
Feature Request Fixed Test Available v2.5
Projects
None yet
Milestone
MathJax v2.5
Development

No branches or pull requests
2 participants
@pkra @dpvc