Rust crypto: allow using a memory store #3536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested review from
germain-gg and
weeman1337
and removed request for
a team
germain-gg
approved these changes
Jul 3, 2023
richvdh
force-pushed
the
rav/element-r/35_verification_request_methods
branch
from
5c99c48 to
283a08a
Compare
It turns out that, for some usecases (in particular, "bot users" for cypress tests), we don't need persistent storage and an in-memory store will be fine.
richvdh
force-pushed
the
rav/element-r/36_rust_crypto_for_cypress_bot
branch
from
d74c5eb to
943e1a6
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
* implement `VerificationRequest.pending` * Implement `VerificationRequest.timeout` * Rust crypto: allow using a memory store (#3536) * Rust crypto: allow using a memory store It turns out that, for some usecases (in particular, "bot users" for cypress tests), we don't need persistent storage and an in-memory store will be fine. * Rust crypto: use a memory store for the unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that, for some usecases (in particular, "bot users" for cypress tests), we don't need persistent storage and an in-memory store will be fine.
(It's worth noting that, for that usecase, we can't just use the default indexeddb store, since that interferes with the store for the client under test. We could use a different prefix for the indexeddb, but it seems like we might as well avoid the overhead of indexeddb altogether.)
We can also use a memory store for the unit tests.
Based on #3532.
Here's what your changelog entry will look like:
✨ Features