This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Cypress: Use Rust crypto for the bot user in verification tests #11173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
richvdh
force-pushed
the
rav/element-r/36_rust_crypto_for_cypress_bot
branch
2 times, most recently
from
da1f473 to
7ad96ac
Compare
richvdh
force-pushed
the
rav/element-r/36_rust_crypto_for_cypress_bot
branch
2 times, most recently
from
ed852fb to
3af577a
Compare
richvdh
commented
Jun 30, 2023
| @@ -59,7 +59,6 @@ export function handleSasVerification(verifier: Verifier): Promise<EmojiMapping[ | |||
|
|
|||
| // @ts-ignore as above, avoiding reference to VerifierEvent | |||
| verifier.on("show_sas", onShowSas); | |||
| verifier.verify(); | |||
There was a problem hiding this comment.
with startVerification, the verify is implicit, so this is no longer needed.
richvdh
force-pushed
the
rav/element-r/37_enable_cypress
branch
from
8738cf5 to
851d398
Compare
richvdh
force-pushed
the
rav/element-r/36_rust_crypto_for_cypress_bot
branch
from
3af577a to
50e86bb
Compare
…Received` matrix-org/matrix-js-sdk#3514 deprecated crypto.verification.request.
matrix-org/matrix-js-sdk#3528 deprecated beginKeyVerification
no functional change here, just combining the various `cy.wrap()`ed things into a single async func
We can already start using the Rust crypto implementation for the "bot" user in the verification tests!
richvdh
force-pushed
the
rav/element-r/36_rust_crypto_for_cypress_bot
branch
from
50e86bb to
9a6e734
Compare
florianduros
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can already start using the Rust crypto implementation for the "bot" user in the verification tests!
I actually want to do this to help me test QR code verification, which is going to mean wiring up QR code scanning, which legacy Crypto doesn't support, and which I would much rather do in the rust impl.
Suggest reviewing commit-by-commit.
Requires matrix-org/matrix-js-sdk#3536.
This change is marked as an internal change (Task), so will not be included in the changelog.