Skip to content

chore: separate mac binary #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

chore: separate mac binary #2198

merged 1 commit into from
Apr 11, 2025

Conversation

hiento09
Copy link
Contributor

Describe Your Changes

  • chore: separate mac binary

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed
    This pull request enhances the macOS build workflow by adding steps to handle separate binaries for different architectures (arm64 and amd64). The most important changes include adding code signing, notarizing, packaging, and uploading artifacts for these separate binaries.

Enhancements to macOS build workflow:

  • Added code signing for separate binaries (arm64 and amd64) in the jobs: section of .github/workflows/template-build-macos.yml.
  • Added notarization steps for the separate binaries using quill in the jobs: section of .github/workflows/template-build-macos.yml.
  • Added packaging steps for the separate binaries, creating tar.gz files for both arm64 and amd64 architectures.
  • Added steps to upload the separate binaries as artifacts using actions/upload-artifact@v4.
  • Added steps to upload release assets for the separate binaries if the public provider is GitHub, using actions/[email protected].

@hiento09 hiento09 force-pushed the feat/separate-mac-binary branch 3 times, most recently from dffa316 to 07b6111 Compare April 10, 2025 07:07
@hiento09 hiento09 requested a review from vansangpfiev April 10, 2025 07:08
@hiento09 hiento09 self-assigned this Apr 10, 2025
@hiento09 hiento09 marked this pull request as ready for review April 10, 2025 07:14
@hiento09 hiento09 force-pushed the feat/separate-mac-binary branch from 07b6111 to c89a2bd Compare April 11, 2025 04:10
@hiento09 hiento09 merged commit 7fda186 into dev Apr 11, 2025
@hiento09 hiento09 deleted the feat/separate-mac-binary branch April 11, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants