Skip to content

chore: separate mac binary #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

chore: separate mac binary #2198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions .github/workflows/template-build-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,14 @@ jobs:
cd engine
make codesign-binary CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}" DESTINATION_BINARY_NAME="${{ steps.set-output-params.outputs.destination_binary_name }}" DESTINATION_BINARY_SERVER_NAME="${{ steps.set-output-params.outputs.destination_binary_server_name }}"

- name: Code Signing binaries for separate binary
run: |
codesign --force -s "${{ secrets.DEVELOPER_ID }}" --options=runtime --entitlements="./engine/templates/macos/entitlements.plist" ./cortex-${{ inputs.new_version }}-mac-arm64/${{ steps.set-output-params.outputs.destination_binary_name }}
codesign --force -s "${{ secrets.DEVELOPER_ID }}" --options=runtime --entitlements="./engine/templates/macos/entitlements.plist" ./cortex-${{ inputs.new_version }}-mac-arm64/${{ steps.set-output-params.outputs.destination_binary_server_name }}

codesign --force -s "${{ secrets.DEVELOPER_ID }}" --options=runtime --entitlements="./engine/templates/macos/entitlements.plist" ./cortex-${{ inputs.new_version }}-mac-amd64/${{ steps.set-output-params.outputs.destination_binary_name }}
codesign --force -s "${{ secrets.DEVELOPER_ID }}" --options=runtime --entitlements="./engine/templates/macos/entitlements.plist" ./cortex-${{ inputs.new_version }}-mac-amd64/${{ steps.set-output-params.outputs.destination_binary_server_name }}

- name: Notary macOS Binary
run: |
curl -sSfL https://raw.githubusercontent.com/anchore/quill/main/install.sh | sh -s -- -b /usr/local/bin
Expand All @@ -265,6 +273,18 @@ jobs:
QUILL_NOTARY_ISSUER: ${{ secrets.NOTARY_ISSUER }}
QUILL_NOTARY_KEY: "/tmp/notary-key.p8"

- name: Notary macOS Binary for separate binary
run: |
# Notarize the binary
quill notarize ./cortex-${{ inputs.new_version }}-mac-arm64/${{ steps.set-output-params.outputs.destination_binary_name }}
quill notarize ./cortex-${{ inputs.new_version }}-mac-arm64/${{ steps.set-output-params.outputs.destination_binary_server_name }}
quill notarize ./cortex-${{ inputs.new_version }}-mac-amd64/${{ steps.set-output-params.outputs.destination_binary_name }}
quill notarize ./cortex-${{ inputs.new_version }}-mac-amd64/${{ steps.set-output-params.outputs.destination_binary_server_name }}
env:
QUILL_NOTARY_KEY_ID: ${{ secrets.NOTARY_KEY_ID }}
QUILL_NOTARY_ISSUER: ${{ secrets.NOTARY_ISSUER }}
QUILL_NOTARY_KEY: "/tmp/notary-key.p8"

- name: Build network Installers
shell: bash
run: |
Expand Down Expand Up @@ -310,6 +330,24 @@ jobs:
xcrun notarytool submit ${{ steps.set-output-params.outputs.package_name }}-local.pkg --apple-id ${{ secrets.APPLE_ID }} --password ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }} --team-id ${{ secrets.APPLE_TEAM_ID }} --wait

- name: Package
run: |
mkdir temp
# Mac arm64
mv cortex-${{ inputs.new_version }}-mac-arm64 temp/cortex
cd temp
tar -czvf cortex-arm64.tar.gz cortex
mv cortex-arm64.tar.gz ../cortex-arm64.tar.gz
cd ..
rm -rf temp/cortex

# Mac amd64
mv cortex-${{ inputs.new_version }}-mac-amd64 temp/cortex
cd temp
tar -czvf cortex-amd64.tar.gz cortex
mv cortex-amd64.tar.gz ../cortex-amd64.tar.gz
cd ..

- name: Package for separate binary
run: |
cd engine
make package
Expand All @@ -320,6 +358,18 @@ jobs:
name: cortex-${{ inputs.new_version }}-mac-universal
path: ./engine/cortex

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: cortex-${{ inputs.new_version }}-mac-arm64-signed
path: ./cortex-${{ inputs.new_version }}-mac-arm64

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: cortex-${{ inputs.new_version }}-mac-amd64-signed
path: ./cortex-${{ inputs.new_version }}-mac-amd64

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -358,6 +408,28 @@ jobs:
asset_name: cortex-${{ inputs.new_version }}-mac-universal.tar.gz
asset_content_type: application/zip

- name: Upload release assert if public provider is github
if: inputs.public_provider == 'github'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: actions/[email protected]
with:
upload_url: ${{ inputs.upload_url }}
asset_path: ./cortex-arm64.tar.gz
asset_name: cortex-${{ inputs.new_version }}-mac-arm64.tar.gz
asset_content_type: application/zip

- name: Upload release assert if public provider is github
if: inputs.public_provider == 'github'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: actions/[email protected]
with:
upload_url: ${{ inputs.upload_url }}
asset_path: ./cortex-amd64.tar.gz
asset_name: cortex-${{ inputs.new_version }}-mac-amd64.tar.gz
asset_content_type: application/zip

- name: Upload release assert if public provider is github
if: inputs.public_provider == 'github'
env:
Expand Down