Skip to content

Increment version in library.properties #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

amilcarlucas
Copy link
Contributor

No description provided.

@pablogs9 pablogs9 requested a review from Acuadros95 March 17, 2022 09:25
@pablogs9
Copy link
Member

@Acuadros95 can you take a look at this? How are we versioning foxy and galactic branch? Can we use the naming vx.y.z-[ros_version] in the Arduino library.properties file?

@Acuadros95
Copy link
Contributor

Acuadros95 commented Mar 17, 2022

@pablogs9 Yes, we can use that versioning, but the initial v is not allowed.
Example: version=2.0.3-foxy

Co-authored-by: Antonio Cuadros <[email protected]>
@amilcarlucas
Copy link
Contributor Author

Changes done

@pablogs9
Copy link
Member

please backport to foxy and main with respective changes

@amilcarlucas
Copy link
Contributor Author

done, 2 new PRs

@pablogs9 pablogs9 merged commit 1979daa into micro-ROS:galactic Mar 17, 2022
@amilcarlucas amilcarlucas deleted the pr-update-version branch March 17, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants