-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Propagate intersectionState
in typeRelatedToSomeType
#56207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot test top100 |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at e7018d2. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at e7018d2. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the tsc-only perf test suite on this PR at e7018d2. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at e7018d2. You can monitor the build here. Update: The results are in! |
@ahejlsberg Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@ahejlsberg Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Hey @ahejlsberg, the results of running the DT tests are ready. |
@ahejlsberg Here are the results of running the top-repos suite comparing Everything looks good! |
At this point, I wonder if we should just make |
Not sure that would help. There are plenty of cases where we don't want to propagate it, so we'd just have to add a bunch of |
Tests and performance look good. I think this one can be merged. |
main...jakebailey:TypeScript:required-intersection-state has the change (which did require moving it up, of course); there are quite a few places that it's not propagated and I didn't hit any places where I needed to add |
Fixes #53412.