-
Notifications
You must be signed in to change notification settings - Fork 640
noslash #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
noslash #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
May 30, 2025
Race mode test failure should be fixed by #1075. |
jakebailey
reviewed
Jun 6, 2025
jakebailey
reviewed
Jun 6, 2025
jakebailey
approved these changes
Jun 6, 2025
jakebailey
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basics of fourslash tests to Corsa.
fourslash
package with the basic setup for running fourslash tests.internal/fourslash/_scripts/convertFourslash.mts
.npm run convertfourslash
to run the script.t.Skip()
. The current list of tests expected to fail is ininternal/fourslash/_scripts/failedTests.txt
.Didn't yet include all the generated tests in the PR because it'd break GitHub.
Included example of a test the script generates: https://github.com/microsoft/typescript-go/pull/991/files#diff-9c51d0662c595fdc5d7eb5e3521e692c744a7711906f1bcceee767b32cfb9252R11
Planning to do in future PRs:
CI action to verify that the checked-in generated fourslash tests match what the script generates.
Better panic handling for the server, and better error message for fourslash tests when server panics.

For reference, here's what a panic in the server currently looks like:
Improve script to parse more completions tests.
Completion baselines.
@iisaduan is working on handling ranges.