Skip to content

noslash #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Jun 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
11307f8
fourslash skeleton
gabritto May 23, 2025
437061f
refactor to test case parser, probably revert later
gabritto May 23, 2025
bb18b40
fourslash basic parsing
gabritto May 24, 2025
fc1391f
use io.Pipe
gabritto May 26, 2025
f3dd294
do some panic recovery
gabritto May 27, 2025
28a330e
don't panic on repeated global options in test parser
gabritto May 27, 2025
34dc3ae
more server/panic/etc fixes
gabritto May 27, 2025
91a3a2d
fix nil references in server and completions, verify completions
gabritto May 28, 2025
c535d3e
Merge branch 'main' into gabritto/noslash
gabritto May 29, 2025
8d8c751
add default capabilities
gabritto May 29, 2025
ab1fe19
refactor server to use lsp message reader/writer
gabritto May 29, 2025
bc81d49
add compiler options for inferred projects in server/service
gabritto May 29, 2025
8116e10
set compiler options in hacky way in fourslash
gabritto May 30, 2025
472745e
add parsed source file caching
gabritto May 30, 2025
a25a3ce
more fourslash completions
gabritto May 30, 2025
29e7273
support expected completion item string
gabritto Jun 2, 2025
744b15c
validate marker character
gabritto Jun 2, 2025
8fb549c
get file name from test name
gabritto Jun 2, 2025
2c5c58f
move things into fourslash package
gabritto Jun 2, 2025
b3cb619
move more things around
gabritto Jun 4, 2025
e9a6f85
WIP: conversion script
gabritto Jun 4, 2025
5da2f95
silence server logs in fourslash
gabritto Jun 4, 2025
e277b2c
clean up script
gabritto Jun 4, 2025
a5a0514
skip failing generated tests
gabritto Jun 4, 2025
a3af405
clean up script, have it read input files from args
gabritto Jun 4, 2025
a823122
fix some blank lines
gabritto Jun 4, 2025
15258be
fix content parsing
gabritto Jun 4, 2025
fc60000
Merge from main
gabritto Jun 4, 2025
dac80f9
fix infinite loop in findPrecedingMatchingToken
gabritto Jun 4, 2025
45f4a48
update failing tests
gabritto Jun 4, 2025
3fd1866
Merge branch 'main' into gabritto/noslash
gabritto Jun 4, 2025
9f0335c
format, lint, etc
gabritto Jun 4, 2025
a0da7e6
add one generated test as example
gabritto Jun 4, 2025
70b3bbf
Merge branch 'main' into gabritto/noslash
gabritto Jun 4, 2025
937a6a6
rename script
gabritto Jun 4, 2025
66b8719
Merge branch 'main' into gabritto/noslash
gabritto Jun 5, 2025
f1a5596
add launch task for fourslash tests
gabritto Jun 5, 2025
a4e364d
redo parsed source file cache
gabritto Jun 5, 2025
fb18438
move script to fourslash
gabritto Jun 5, 2025
bec9c69
Merge branch 'main' into gabritto/noslash
gabritto Jun 5, 2025
fb393e5
use t.cleanup
gabritto Jun 5, 2025
220b3d5
use local ptrTo
gabritto Jun 5, 2025
0a7caf0
renames, fix script helper
gabritto Jun 5, 2025
3415325
remove select
gabritto Jun 6, 2025
bd57d92
use stringutil
gabritto Jun 6, 2025
4333d1c
Merge branch 'main' into gabritto/noslash
gabritto Jun 6, 2025
31277f6
fix merge
gabritto Jun 6, 2025
d91b010
fix lint
gabritto Jun 6, 2025
c91f099
format, add helper
gabritto Jun 6, 2025
7b534c8
format script
gabritto Jun 6, 2025
38034bc
Merge branch 'main' into gabritto/noslash
gabritto Jun 6, 2025
56d2ac4
rename scripts folder, remove package.json, add command to top-level …
gabritto Jun 6, 2025
634e00f
don't change npm versions
gabritto Jun 6, 2025
1404efd
Merge branch 'main' into gabritto/noslash
gabritto Jun 6, 2025
d4a9fab
CR
gabritto Jun 6, 2025
277edad
format generated files
gabritto Jun 6, 2025
c1c3933
format script
gabritto Jun 6, 2025
157de4d
update failing tests, add all generated tests
gabritto Jun 6, 2025
5e1881c
organize failing tests list
gabritto Jun 6, 2025
a244789
skip with noembed
gabritto Jun 6, 2025
41eec38
Revert "skip with noembed"
gabritto Jun 6, 2025
406788b
skip if no embed inside fourslash
gabritto Jun 6, 2025
eeb5b6a
update failing tests once again
gabritto Jun 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,5 @@ custom-gcl.hash
!testdata/submoduleAccepted.txt

!NOTICE.txt

!internal/fourslash/_scripts/failingTests.txt
7 changes: 7 additions & 0 deletions .vscode/launch.template.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@
"-test.run",
"TestSubmodule/${fileBasename}"
]
},
{
"name": "Launch fourslash test",
"type": "go",
"request": "launch",
"mode": "test",
"program": "${workspaceFolder}/internal/fourslash/gen/${fileBasename}"
}
]
}
4 changes: 2 additions & 2 deletions cmd/tsgo/lsp.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ func runLSP(args []string) int {
typingsLocation := getGlobalTypingsCacheLocation()

s := lsp.NewServer(&lsp.ServerOptions{
In: os.Stdin,
Out: os.Stdout,
In: lsp.ToReader(os.Stdin),
Out: lsp.ToWriter(os.Stdout),
Err: os.Stderr,
Cwd: core.Must(os.Getwd()),
FS: fs,
Expand Down
Loading
Loading