Remove code lenses for "set as interpreter"

[AlJohri]

#736

I don't know if you have usage statistics on this but it seems more annoying than useful. I am almost always working within a virtualenv which I set by clicking on the bottom left and selecting my python interpreter.

The hashbang by design is super generic, like #!/usr/bin/env python3. Clicking "set as interpreter" just changes it to system python which is almost always not useful, especially when you're already in a virtualenv.

I recommend removing this suggestion all together or at the very least removing it when the python path is explicitly listed in settings.json

[gimbo]

Agreed; or at least there should be a way to hide this hint via settings.json. Right now the hint permanently wastes vertical real estate and the only way to get rid of it (AFAICS, and assuming this comment is still true) is to delete the shebang line.

[ablakey]

This is probably overkill but it may help some people.

This notification is powered by Code Lens. If you set "editor.codeLens": false, in your custom settings, it goes away. Note this also kills some other features, none of which I seem to be using for Python, but you might be! Here's a brief overview of what kinds of features are powered by it: https://code.visualstudio.com/blogs/2017/02/12/code-lens-roundup

[AlJohri]

I seem to use CodeLens quite a bit from your link.

I'd advocate for removing it once the python has been explicitly set by user action.

[silkfire]

Any update on this?

[tgotwig]

How to reproduce? 🤔

[brettcannon]

We are going through old issues and we noticed that no one from the team had replied to this issue. I want to apologize for the oversight and to let you know that the issue was reviewed by the team and triaged (as shown by the labels applied to this issue).

[francois-rozet]

Hello, I too find this very annoying. Not to mention that the hint moves up and down as I type...

I think this could be very easily solved by adding something like

if (this.workspace.getInterpreter() !== undefined) {
    return [];
}

at

vscode-python/src/client/interpreter/display/shebangCodeLensProvider.ts

Line 64 in 411d1d4

private async createShebangCodeLens(document: TextDocument) {

Unfortunately, I am not familiar with this extension, so I don't know how to workspace.getInterpreter() in practice.

---

I've looked into it a bit more, and it seems that we could use the public _pythonPathSetting variable of the InterpreterService as condition. Something like,

if (this.interpreterService._pythonPathSetting === '') {
    return [];
}

However, I don't think ShebangCodeLensProvider has access to interpreterService currently (?). Maybe does it require to add

@inject(IInterpreterService) interpreterService: IInterpreterService

in the constructor.

@brettcannon do you have any tip about this ?

[brettcannon]

@francois-rozet That leading underscore means you shouldn't be poking around at it. 😄

@luabud is the "needs PR" for dropping the feature or for making it disappear when the environment has been chosen?

[francois-rozet]

@francois-rozet That leading underscore means you shouldn't be poking around at it. 😄

Oh my bad. Then adding a getter to that variable (getPythonPathSetting) or a property/method like isInterpreterSet (returning a boolean) could do the trick.

[luabud]

@brettcannon I believe we originally have agreed to hide it once the interpreter is set. I think we should open a discussion about removing this feature though 🤔

[zhongxiang117]

As an addition, I too feel it a little bit annoying, any updates on it?

I would like to add more info on it, my VSCode & Python-extension Version:

VSCode Version:
Version: 1.55.0 (user setup)
Commit: c185983a683d14c396952dd432459097bc7f757f
Date: 2021-03-30T16:01:55.261Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.18363
Python-extension version: v2021.3.680753044

As you can see, my OS is windows, after thoroughly read this #736, I found the problem is caused by using Shebang.

If I remove Shebang line, the info will be gone. However, I do want to keep this code interpreter hint line.

[brettcannon]

@zhongxiang117 no updates as no one has participated in any discussion. 😄

[zhongxiang117]

@brettcannon , that is sad, but the issue is still open. Hope you can soon or happen to fix them..

[brettcannon]

@zhongxiang117 to be clear, when I say "no one has participated in any discussion" I mean in this issue, not our team so we are currently not the hold-up on this. IOW no one has said whether they think full removal is better than simply hiding the lens if the interpreter has been set.

[francois-rozet]

@brettcannon I don't think the feature is very useful in itself, so it could be completely removed. Otherwise, hiding is fine and I think it can be implemented very fast as I mentioned above (#3854 (comment)).

[msftwindowslinux]

+1 that this is a largely useless feature worth dropping (commenting instead of thumbs-upping in hopes this moves the needle on "sufficient discussion")

[karrtikr]

Hi everyone 👋

You can add the following to your User settings as a workaround:

    "[python]": {
        "editor.codeLens": false,
    }

Search for Open settings (json) in the command palette to open the settings file. We plan to change this to a lightbulb fix suggestion instead so it's not as distracting.

[luabud]

This one is about removing https://github.com/microsoft/vscode-python/blob/main/src/client/interpreter/display/shebangCodeLensProvider.ts as well as references to it

[ChinazoOnwukaike]

Assign this to me please.