Skip to content

Remove code lenses for "set as interpreter" #19853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

ChinazoOnwukaike
Copy link

@ChinazoOnwukaike ChinazoOnwukaike commented Sep 16, 2022

Closes #3854

Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as their references and instances. Also removed the setShebangInterpreter.

…s their references and instances. Also removed the setShebangInterpreter
@ghost
Copy link

ghost commented Sep 16, 2022

CLA assistant check
All CLA requirements met.

@luabud luabud added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Sep 16, 2022
@@ -100,11 +100,6 @@ export interface IInterpreterDisplay {
registerVisibilityFilter(filter: IInterpreterStatusbarVisibilityFilter): void;
}

export const IShebangCodeLensProvider = Symbol('IShebangCodeLensProvider');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have to remove the CodeLensProvider and TextDocument imports on line 2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig Hi Karthik! Just removed those and pushed the changes. Everything is passing now.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the references as well.

@karrtikr karrtikr changed the title remove shebangCodeLensProvider and IShebangCodeLensProvider as well a… Remove code lenses for "set as interpreter" Sep 16, 2022
@karrtikr
Copy link

karrtikr commented Sep 16, 2022

Renamed the PR appropriately as that is what goes into our release notes. Also edited PR description to reference the issue this PR was about.

@karrtikr karrtikr merged commit d44e877 into microsoft:main Sep 16, 2022
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Oct 4, 2022
Closes microsoft#3854

Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as
their references and instances. Also removed the setShebangInterpreter.
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…19853)

Closes microsoft/vscode-python#3854

Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as
their references and instances. Also removed the setShebangInterpreter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code lenses for "set as interpreter"
4 participants