Skip to content

Reword message for A/B testing in the output channel #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luabud opened this issue Jun 26, 2019 · 7 comments
Closed

Reword message for A/B testing in the output channel #6352

luabud opened this issue Jun 26, 2019 · 7 comments
Assignees
@Vidushi-Gupta
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug good first issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2021

Comments

@luabud
Copy link
Member

luabud commented Jun 26, 2019

Currently we display: User in experiment X

We should improve it to: Experiment in place: X

cc @qubitron
@luabud luabud added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Jun 26, 2019
@qubitron
Copy link

How about Experiment "X" is active?

@luabud
Copy link
Member Author

luabud commented Jun 26, 2019

Sure

@brettcannon brettcannon added needs PR feature-request Request for new features or functionality good first issue and removed triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Jun 27, 2019
@luabud luabud added area-editor-* User-facing catch-all and removed feature-* labels May 13, 2020
@vvijayalakshmi21
Copy link

Hi,
I can see a description on the same lines (given below) in package.nls.json file:
"Experiments.inGroup": "User belongs to experiment group '{0}'"

Should this be reworded to "Experiment {0} is active" ?

@luabud
Copy link
Member Author

luabud commented Jan 27, 2021

Hi @vvijayalakshmi21, sorry for the delay!
There is one of the files where this should be reworded, yes. I believe the other one is localize.ts 😊

@Vidushi-Gupta
Copy link

Hi, I would want to try working on this issue for the OSD!

@Vidushi-Gupta Vidushi-Gupta mentioned this issue Oct 1, 2021
Merged
karthiknadig pushed a commit that referenced this issue Oct 1, 2021
@Vidushi-Gupta
Reworded message for A/B testing in the output channel as per issue #…
b72856e 
…6352 (#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this issue Oct 4, 2021
@Vidushi-Gupta @karthiknadig
Reworded message for A/B testing in the output channel as per issue m…
b5a3166 
…icrosoft#6352 (microsoft#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md
karthiknadig added a commit that referenced this issue Oct 4, 2021
@karthiknadig @brettcannon
@kimadeline @Vidushi-Gupta @IceJinx33 @arsentieva @Carolinekung2 @Quynhd07
Update osd (#17612)
5a1edb7 
* Add a quick note about limited support on the web

* Tweak the description for virtual workspaces support

Closes #17600

* Update to vscode-extension-telemetry 0.4.2 (#17608)

* Update to vscode-extension-telemetry 0.4.2

* Add news

* Update to latest version of Jedi LS (#17591)

* Update to latest version of Jedi LS

* Add news

* Release candidate (#17610)

* Update version

* Update change logs

* Update notice

* Update main branch version (#17611)

* Reworded message for A/B testing in the output channel as per issue #6352 (#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md

* Added replaceAll for string prototype & unit tests (#17582)

* Added replaceAll for string prototype & unit tests

* Create 15288.md

* Bug Fix: use replaceAll for replacing separators.

* Ran prettier on updated files.

Co-authored-by: Aliva Das <[email protected]>

* Issue #17019: Reword commands in Run/Debug button in editor title (#17592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Update python version in brew command (#17593)

* Update python version in brew command

Previously brew command installed python version 2 (outdated). Now brew command will install python 3.

* Create 17590.md

* Rewording news file description

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Improve setting description for enabling A/B tests (#17585)

* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement

* Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters  (#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Vidushi Gupta <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Anna Arsentieva <[email protected]>
Co-authored-by: Carolinekung2 <[email protected]>
Co-authored-by: Thi Le <[email protected]>
Co-authored-by: Quynhd07 <[email protected]>
Co-authored-by: Quynh <[email protected]>
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this issue Oct 13, 2021
@Vidushi-Gupta @karthiknadig
Reworded message for A/B testing in the output channel as per issue m…
7503d6c 
…icrosoft#6352 (microsoft#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md
karthiknadig pushed a commit that referenced this issue Oct 13, 2021
@Vidushi-Gupta @karthiknadig
Reworded message for A/B testing in the output channel as per issue #…
0dc337f 
…6352 (#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md
@kimadeline kimadeline added this to the October 2021 milestone Oct 21, 2021
@kimadeline kimadeline added the verification-needed Verification of issue is requested label Oct 21, 2021
@kimadeline
Copy link

Verification steps:

  • Activate the extension
  • Open the Python output channel, and verify that the message for experiments is Experiment <name> is active

@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Oct 27, 2021
@IanMatthewHuff
Copy link
Member

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Vidushi-Gupta Vidushi-Gupta

Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug good first issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
7 participants
@brettcannon @IanMatthewHuff @qubitron @vvijayalakshmi21 @luabud @kimadeline @Vidushi-Gupta