Skip to content

Reword commands in Run/Debug button in editor title #17019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
byehack opened this issue Aug 18, 2021 · 10 comments · Fixed by #17592 or #17594
Closed

Reword commands in Run/Debug button in editor title #17019

byehack opened this issue Aug 18, 2021 · 10 comments · Fixed by #17592 or #17594
Assignees
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality good first issue

Comments

@byehack
Copy link

byehack commented Aug 18, 2021

support https://code.visualstudio.com/updates/v1_59#_improved-rundebug-button-in-editor-title for python files

@byehack byehack added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Aug 18, 2021
@karthiknadig
Copy link
Member

This is already done in insiders version of Python:
image

@byehack byehack closed this as completed Aug 18, 2021
@byehack
Copy link
Author

byehack commented Aug 18, 2021

i think Run Python and Debug Python are proper names.

@byehack byehack reopened this Aug 18, 2021
@karthiknadig
Copy link
Member

/cc @luabud

@karthiknadig karthiknadig added area-editor-* User-facing catch-all needs decision and removed triage-needed Needs assignment to the proper sub-team labels Aug 19, 2021
@karthiknadig
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

@byehack
Copy link
Author

byehack commented Aug 23, 2021

like java:
image

actually File in Terminal are extra words.
because there is not another way except terminal to run/debug.

@luabud luabud added needs community feedback Awaiting community feedback and removed needs decision labels Sep 2, 2021
@luabud
Copy link
Member

luabud commented Sep 2, 2021

I like the "File" there because this button uses the "Python file" configuration under the hood, and it won't work for debugging a Flask or Django project, for example. But I agree "in terminal" may not be necessary.

@byehack
Copy link
Author

byehack commented Sep 15, 2021

because this button uses the "Python file" configuration under the hood, and it won't work for debugging a Flask or Django project, for example.

can we add other configurations in there?
image

or at least that python configurations are set in user settings? (also can add workspace/folder configurations if that file is in there.)

"launch": {
        "version": "0.2.0",
        "configurations": [
            {
                "name": "Debug Python",
                "type": "python",
                "request": "launch",
                "program": "${file}",
                "cwd": "${fileDirname}",
                "justMyCode": false,
                "internalConsoleOptions": "neverOpen"
            }
        ]
    }

i use this configuration in user settings for debug python files.
now i should use debug panel every time and in-editor debug button is useless.

@luabud
Copy link
Member

luabud commented Oct 1, 2021

@byehack created #17583 to track your feature request. I'll keep this issue to track the renaming of the commands in the button to "Run Python file" and "Debug Python file"

@luabud luabud added good first issue and removed needs community feedback Awaiting community feedback labels Oct 1, 2021
@luabud luabud changed the title Improved Run/Debug button in editor title Reword commands in Run/Debug button in editor title Oct 1, 2021
@thi-lehoangy
Copy link

I can take this issue

@arsentieva
Copy link

@luabud can i take this issue?

kimadeline pushed a commit that referenced this issue Oct 1, 2021
…7592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>
@karrtikr karrtikr closed this as completed Oct 1, 2021
karthiknadig added a commit to karthiknadig/vscode-python that referenced this issue Oct 4, 2021
…title (microsoft#17592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>
karthiknadig added a commit that referenced this issue Oct 4, 2021
* Add a quick note about limited support on the web

* Tweak the description for virtual workspaces support

Closes #17600

* Update to vscode-extension-telemetry 0.4.2 (#17608)

* Update to vscode-extension-telemetry 0.4.2

* Add news

* Update to latest version of Jedi LS (#17591)

* Update to latest version of Jedi LS

* Add news

* Release candidate (#17610)

* Update version

* Update change logs

* Update notice

* Update main branch version (#17611)

* Reworded message for A/B testing in the output channel as per issue #6352 (#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md

* Added replaceAll for string prototype & unit tests (#17582)

* Added replaceAll for string prototype & unit tests

* Create 15288.md

* Bug Fix: use replaceAll for replacing separators.

* Ran prettier on updated files.

Co-authored-by: Aliva Das <[email protected]>

* Issue #17019: Reword commands in Run/Debug button in editor title (#17592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Update python version in brew command (#17593)

* Update python version in brew command

Previously brew command installed python version 2 (outdated). Now brew command will install python 3.

* Create 17590.md

* Rewording news file description

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Improve setting description for enabling A/B tests (#17585)

* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement

* Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters  (#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Vidushi Gupta <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Anna Arsentieva <[email protected]>
Co-authored-by: Carolinekung2 <[email protected]>
Co-authored-by: Thi Le <[email protected]>
Co-authored-by: Quynhd07 <[email protected]>
Co-authored-by: Quynh <[email protected]>
karthiknadig added a commit to karthiknadig/vscode-python that referenced this issue Oct 13, 2021
…title (microsoft#17592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>
karthiknadig added a commit that referenced this issue Oct 13, 2021
…7592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality good first issue
Projects
None yet
6 participants