Use a single language server instance when type set to Node #11315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #11315 +/- ##
==========================================
+ Coverage 61.12% 61.46% +0.33%
==========================================
Files 601 606 +5
Lines 33128 33812 +684
Branches 4680 4790 +110
==========================================
+ Hits 20249 20781 +532
- Misses 11861 12579 +718
+ Partials 1018 452 -566
Continue to review full report at Codecov.
|
jakebailey
commented
Apr 22, 2020
| const configurationService = this.serviceContainer.get<IConfigurationService>(IConfigurationService); | ||
| const serverType = configurationService.getSettings(this.resource).languageServer; | ||
| if (serverType === LanguageServerType.Node) { | ||
| return 'shared-ls'; |
There was a problem hiding this comment.
This ensures only a single instance is used.
jakebailey
commented
Apr 22, 2020
| import { ILanguageServerOutputChannel } from '../types'; | ||
|
|
||
| @injectable() | ||
| export class NodeLanguageServerAnalysisOptions extends LanguageServerAnalysisOptionsBase { |
There was a problem hiding this comment.
Empty class; no options are needed to configure this other than the defaults.
jakebailey
added a commit
to jakebailey/vscode-python
that referenced
this pull request
Apr 26, 2020
10 tasks
jakebailey
added a commit
that referenced
this pull request
Apr 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits apart
analysisOptions.tsinto two implementations, switching between them depending on the language server type setting. It also makes the LS key a static string to ensure only a single instance is spawned.This means that the LS can be started without any document selectors (eventually leading to handling of #5132), and only have a single instance to handle all workspaces at once.
Also, while moving this code, delete some ancient deprecated options which no recent LS has used.
While working on this, I discovered the reason for #5132 (comment); I'll file a new issue about that as it's out of scope for this PR.
Has a news entry file (remember to thank yourself!).Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.