Skip to content

Fix regression in typeshed/exclude paths from #11315 #11420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

jakebailey
Copy link
Member

Fixes a regression I accidentally introduced in #11315. The typeshed and exclude paths weren't being set, breaking the LS and change events.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@jakebailey jakebailey added the no-changelog No news entry required label Apr 26, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Apr 26, 2020

Codecov Report

Merging #11420 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11420      +/-   ##
==========================================
- Coverage   61.04%   61.01%   -0.03%     
==========================================
  Files         613      613              
  Lines       33612    33614       +2     
  Branches     4750     4750              
==========================================
- Hits        20517    20511       -6     
+ Misses      12648    12072     -576     
- Partials      447     1031     +584     
Impacted Files Coverage Δ
...lient/activation/languageServer/analysisOptions.ts 58.41% <0.00%> (-1.19%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/testing/main.ts 14.38% <0.00%> (ø)
src/client/common/editor.ts 8.25% <0.00%> (ø)
src/client/linters/flake8.ts 85.71% <0.00%> (ø)
src/client/linters/pylint.ts 98.27% <0.00%> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34770bb...7ff8f29. Read the comment docs.

@jakebailey jakebailey merged commit b841e5f into microsoft:master Apr 26, 2020
@jakebailey jakebailey deleted the fix-ls-typeshed branch April 26, 2020 18:22
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants