Skip to content

Initialize/activate the ExtensionLocators when the extension activates. #13498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Aug 18, 2020

This finishes up work on "interfaces and scaffolding needed for locators". At this point we can plug this "locator manager" into the discovery component API, as well as plug the low-level locators in here.

This is based on #13780.

The only files changed in this PR are:

  • src/client/extensionInit.ts
  • src/client/pythonEnvironments/index.ts

So you should only need to review those here. For all the other files please go to the other PR.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #13498 into main will increase coverage by 0.04%.
The diff coverage is 89.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13498      +/-   ##
==========================================
+ Coverage   59.91%   59.96%   +0.04%     
==========================================
  Files         682      684       +2     
  Lines       37935    38029      +94     
  Branches     5462     5477      +15     
==========================================
+ Hits        22730    22804      +74     
+ Misses      14046    14043       -3     
- Partials     1159     1182      +23     
Impacted Files Coverage Δ
...ent/pythonEnvironments/discovery/locators/index.ts 87.93% <89.70%> (+2.21%) ⬆️
src/client/common/utils/async.ts 87.50% <100.00%> (ø)
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 56.00% <0.00%> (-8.00%) ⬇️
...rc/client/datascience/notebookStorage/baseModel.ts 64.28% <0.00%> (-3.14%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/logging/logger.ts 62.74% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329292c...b4afa82. Read the comment docs.

@karrtikr karrtikr assigned karrtikr and unassigned karrtikr Aug 24, 2020
@ericsnowcurrently ericsnowcurrently force-pushed the locators-api branch 5 times, most recently from 5c3a84d to 04cb74e Compare August 27, 2020 22:17
@ericsnowcurrently ericsnowcurrently force-pushed the locators-api branch 6 times, most recently from 636b062 to 41f0f4b Compare September 3, 2020 20:26
@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Sep 3, 2020
@ericsnowcurrently ericsnowcurrently changed the title Add a low-level lib for Python environments. Initialize/activate the ExtensionLocators when the extension activates. Sep 3, 2020
@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review September 3, 2020 20:40
@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main September 3, 2020 21:06
@kimadeline
Copy link

Oh, I guess I should've left my comments in #13780 since the files I commented on are part of #13780, sorry about that. Let me know if you want me to move my comments over there.

@ericsnowcurrently
Copy link
Author

If you don't mind moving those, that would be super helpful. Thanks!

@ericsnowcurrently
Copy link
Author

Sorry for making this PR complicated by the other one. I got impatient. 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2020

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently ericsnowcurrently merged commit 6bad0ef into microsoft:main Sep 9, 2020
@ericsnowcurrently ericsnowcurrently deleted the locators-api branch September 9, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants