Skip to content

Add an extension-specific locator that will wrap the low-level locators. #13780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link

(Note that most of this PR is new tests.)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #13780 into main will increase coverage by 0.09%.
The diff coverage is 86.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13780      +/-   ##
==========================================
+ Coverage   59.91%   60.01%   +0.09%     
==========================================
  Files         682      685       +3     
  Lines       37935    38086     +151     
  Branches     5462     5487      +25     
==========================================
+ Hits        22730    22857     +127     
+ Misses      14046    14045       -1     
- Partials     1159     1184      +25     
Impacted Files Coverage Δ
src/client/common/utils/async.ts 84.94% <71.42%> (-2.56%) ⬇️
...ent/pythonEnvironments/discovery/locators/index.ts 87.93% <89.70%> (+2.21%) ⬆️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 56.00% <0.00%> (-8.00%) ⬇️
...rc/client/datascience/notebookStorage/baseModel.ts 64.28% <0.00%> (-3.14%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/logging/logger.ts 62.74% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329292c...8e34000. Read the comment docs.

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main September 3, 2020 21:06
@kimadeline
Copy link

Some linting issues (pipeline):

image

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer if my comment was addressed, but not blocking.

Note that the uses for ... of are going to generate ESLint warnings, and array iterations should be preferred whenever possible.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ericsnowcurrently ericsnowcurrently merged commit b6ee6c6 into microsoft:main Sep 9, 2020
@ericsnowcurrently ericsnowcurrently deleted the pyenvs-component-ext-locator branch September 9, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants