-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add an extension-specific locator that will wrap the low-level locators. #13780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extension-specific locator that will wrap the low-level locators. #13780
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13780 +/- ##
==========================================
+ Coverage 59.91% 60.01% +0.09%
==========================================
Files 682 685 +3
Lines 37935 38086 +151
Branches 5462 5487 +25
==========================================
+ Hits 22730 22857 +127
+ Misses 14046 14045 -1
- Partials 1159 1184 +25
Continue to review full report at Codecov.
|
Some linting issues (pipeline): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer if my comment was addressed, but not blocking.
Note that the uses for ... of
are going to generate ESLint warnings, and array iterations should be preferred whenever possible.
Kudos, SonarCloud Quality Gate passed!
|
(Note that most of this PR is new tests.)
[ ] Has a news entry file (remember to thank yourself!).[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate.[ ]package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.