Skip to content

Disable surveys if running in codespaces #14332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 9, 2020
Merged

Disable surveys if running in codespaces #14332

merged 7 commits into from
Oct 9, 2020

Conversation

joyceerhl
Copy link

For https://github.com/microsoft/vscode-python/issues/14330

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Oct 8, 2020
@rchiodo
Copy link

rchiodo commented Oct 8, 2020

I'm not sure this is the sum total of all surveys? Anything that implements IPythonExtensionBanner is likely also a survey?

@joyceerhl
Copy link
Author

@rchiodo no, the other two implementations of IPythonExtensionBanner are

  • shift enter banner
  • use pylance banner

@luabud
Copy link
Member

luabud commented Oct 8, 2020

Awesome!! Thanks for including the Python extension survey on this 🤩 is the debugger survey included too by any chance?

@joyceerhl
Copy link
Author

@luabud included the debugger survey. I also noticed that the core team optionally shows either a survey (aka.ms/mailingListSurvey) or a tip (from #13554), what would you like me to do about that one?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joyceerhl joyceerhl merged commit 4ef9253 into main Oct 9, 2020
@joyceerhl joyceerhl deleted the codespaces branch October 9, 2020 05:26
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
* Disable surveys if running in codespaces

* Also disable debugger survey

* Disable gather survey in codespaces too

* For gather, show a description without the survey

* Fixes for IW tests where UIKind is not defined

* Fix all the tests where UIKind is not defined

* Appease hygiene
DonJayamanne pushed a commit that referenced this pull request Oct 30, 2020
…-jupyter (#194)

* Fix sample notebook to state that you can double click to edit a cell (#14238)

* Disable surveys if running in codespaces (#14332)

* Disable surveys if running in codespaces

* Disable gather survey in codespaces too

* For gather, show a description without the survey

* Fixes for IW tests where UIKind is not defined

* Fix all the tests where UIKind is not defined

* Appease hygiene

* Disable mailing list if running in Codespaces (#14347)

* Show tensor dimensions in variable explorer (#14244)

* Fix markdown cell marker formatting for export to Python (#14360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants