Disable surveys if running in codespaces #14332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
requested review from
IanMatthewHuff,
DonJayamanne,
jmew,
rchiodo,
DavidKutu and
luabud
|
I'm not sure this is the sum total of all surveys? Anything that implements |
|
@rchiodo no, the other two implementations of IPythonExtensionBanner are
|
brettcannon
approved these changes
Oct 8, 2020
rchiodo
approved these changes
Oct 8, 2020
|
Awesome!! Thanks for including the Python extension survey on this 🤩 is the debugger survey included too by any chance? |
IanMatthewHuff
approved these changes
Oct 8, 2020
DavidKutu
approved these changes
Oct 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
10 tasks
luabud
pushed a commit
to luabud/vscode-python
that referenced
this pull request
Oct 26, 2020
* Disable surveys if running in codespaces * Also disable debugger survey * Disable gather survey in codespaces too * For gather, show a description without the survey * Fixes for IW tests where UIKind is not defined * Fix all the tests where UIKind is not defined * Appease hygiene
DonJayamanne
pushed a commit
that referenced
this pull request
Oct 30, 2020
…-jupyter (#194) * Fix sample notebook to state that you can double click to edit a cell (#14238) * Disable surveys if running in codespaces (#14332) * Disable surveys if running in codespaces * Disable gather survey in codespaces too * For gather, show a description without the survey * Fixes for IW tests where UIKind is not defined * Fix all the tests where UIKind is not defined * Appease hygiene * Disable mailing list if running in Codespaces (#14347) * Show tensor dimensions in variable explorer (#14244) * Fix markdown cell marker formatting for export to Python (#14360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-python/issues/14330
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).