Skip to content

Disable mailing list if running in codespaces #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Disable mailing list if running in codespaces #14347

merged 1 commit into from
Oct 9, 2020

Conversation

joyceerhl
Copy link

For #14330

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Oct 9, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joyceerhl joyceerhl merged commit 1b83167 into main Oct 9, 2020
@joyceerhl joyceerhl deleted the mailing-list branch October 9, 2020 18:57
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
@joyceerhl @luabud
Disable mailing list if running in Codespaces (microsoft#14347)
ddfbd77
DonJayamanne pushed a commit that referenced this pull request Oct 30, 2020
@joyceerhl
Port joyceerhl's commits from vscode-python since the split to vscode…
b993b34 
…-jupyter (#194)

* Fix sample notebook to state that you can double click to edit a cell (#14238)

* Disable surveys if running in codespaces (#14332)

* Disable surveys if running in codespaces

* Disable gather survey in codespaces too

* For gather, show a description without the survey

* Fixes for IW tests where UIKind is not defined

* Fix all the tests where UIKind is not defined

* Appease hygiene

* Disable mailing list if running in Codespaces (#14347)

* Show tensor dimensions in variable explorer (#14244)

* Fix markdown cell marker formatting for export to Python (#14360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@luabud luabud Awaiting requested review from luabud

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyceerhl @IanMatthewHuff @karthiknadig @rchiodo @DavidKutu