Skip to content

Rename commands in Run/Debug button #17594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2021
Merged

Rename commands in Run/Debug button #17594

merged 3 commits into from
Oct 7, 2021

Conversation

analiabs
Copy link

@analiabs analiabs commented Oct 1, 2021 •
edited by karrtikr
Loading

Closes #17019

@ghost
Copy link

ghost commented Oct 1, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

karrtikr
karrtikr approved these changes Oct 1, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, happy OSD!

@karrtikr
Copy link

karrtikr commented Oct 1, 2021

Seems like this has already been taken care of: #17592. Closing this.

@karrtikr karrtikr closed this Oct 1, 2021
@luabud luabud reopened this Oct 1, 2021
@luabud
Copy link
Member

luabud commented Oct 1, 2021

@karrtikr sorry, I instructed her to send this PR because we in the previous PR the python.command.python.execInTerminal.title was updated when we wanted to only update the one used in the Icon 😅 I can create a separate issue if that would be better

@luabud luabud added the skip package*.json package.json and package-lock.json don't both need updating label Oct 1, 2021
@karrtikr karrtikr changed the base branch from main to OSD October 1, 2021 23:00
@karrtikr
Copy link

karrtikr commented Oct 1, 2021

Oh I see.

@analiabs Can you please rebase this PR off OSD branch? As that has already accepted a similar contribution, there're some merge conflicts.

karrtikr
karrtikr reviewed Oct 2, 2021
View reviewed changes
@karrtikr karrtikr self-requested a review October 2, 2021 00:33
@karrtikr karrtikr merged commit 8ce774f into microsoft:OSD Oct 7, 2021
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 13, 2021
@analiabs @karthiknadig
Rename commands in Run/Debug button (microsoft#17594)
3d2b32f 
* Solve merge conflits

* Rename commands in Run/Debug button - new entry

* Update news/2 Fixes/17019.md

Co-authored-by: Kartik Raj <[email protected]>
karthiknadig pushed a commit that referenced this pull request Oct 13, 2021
@analiabs @karthiknadig
Rename commands in Run/Debug button (#17594)
44d51ef 
* Solve merge conflits

* Rename commands in Run/Debug button - new entry

* Update news/2 Fixes/17019.md

Co-authored-by: Kartik Raj <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@analiabs @wesm
Rename commands in Run/Debug button (microsoft/vscode-python#17594)
df9e2b5 
* Solve merge conflits

* Rename commands in Run/Debug button - new entry

* Update news/2 Fixes/17019.md

Co-authored-by: Kartik Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@karrtikr karrtikr

Labels
skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reword commands in Run/Debug button in editor title
3 participants
@analiabs @karrtikr @luabud