Skip to content

[UnitTests] Add more UTs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

[UnitTests] Add more UTs #139

merged 3 commits into from
Apr 3, 2025

Conversation

stvansolano
Copy link
Contributor

@stvansolano stvansolano commented Mar 29, 2025 •
edited
Loading

Added UTs for code not tested/covered:

  • McpClientExtensions
  • McpClientFactory

Added tests around content resources (text, images, resources, etc) and sampling/handlers

Motivation and Context

  • Increase code coverage
  • Handle unhappy scenarios (unhappy / throws) accordingly.

How Has This Been Tested?

All UT pass

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • More tests

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

@stvansolano
Copy link
Contributor Author

+ @stephentoub @eiriktsarpalis LMK

@stvansolano stvansolano force-pushed the stvansolano/add-more-tests branch from a8e28c7 to e9bb15f Compare March 31, 2025 19:53
@stvansolano
Copy link
Contributor Author

Addressed merge conflicts per #160 recent changes. cc @stephentoub

@stvansolano stvansolano force-pushed the stvansolano/add-more-tests branch from 4584f2c to eadb432 Compare April 3, 2025 00:50
@stvansolano stvansolano force-pushed the stvansolano/add-more-tests branch from eadb432 to dc2221b Compare April 3, 2025 02:32
@stvansolano
Copy link
Contributor Author

Ready for another look

@stephentoub stephentoub merged commit c70dde3 into modelcontextprotocol:main Apr 3, 2025
8 checks passed
@stephentoub
Copy link
Contributor

Thanks.

@stvansolano stvansolano deleted the stvansolano/add-more-tests branch April 4, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stvansolano @stephentoub @eiriktsarpalis