Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ModelContextProtocol.AspNetCore #160

Merged
merged 6 commits into from
Mar 31, 2025
Merged

Add ModelContextProtocol.AspNetCore #160

merged 6 commits into from
Mar 31, 2025

Conversation

halter73
Copy link
Contributor

  • Remove IServerTransport and HttpListenerSseServerTransport. Replace its usage in tests with ASP.NET Core.

@halter73
Add ModelContextProtocol.AspNetCore
f660bb8 
- Remove IServerTransport

- Canceling read from stdin in StdioServerTransport.DisposeAsync is also flaky on Windows
- https://github.com/modelcontextprotocol/csharp-sdk/actions/runs/14161333333/job/39667212874
@eiriktsarpalis eiriktsarpalis mentioned this pull request Mar 31, 2025
Open
jeffhandley
jeffhandley approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the build/infrastructure perspective

@halter73 halter73 merged commit 973c7c0 into modelcontextprotocol:main Mar 31, 2025
8 checks passed
@stvansolano stvansolano mentioned this pull request Mar 31, 2025
Merged
10 tasks
@halter73 halter73 mentioned this pull request Apr 1, 2025
Merged
@IshamMohamed IshamMohamed mentioned this pull request Apr 3, 2025
Closed
@IshamMohamed
Copy link

Invalidates #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@jeffhandley jeffhandley jeffhandley approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@PederHP PederHP Awaiting requested review from PederHP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@halter73 @IshamMohamed @jeffhandley @stephentoub @eiriktsarpalis