-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable servers to log to the clients via ILogger #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/ModelContextProtocol.Tests/Client/McpClientExtensionsTests.cs:414
- The list 'data' is incorrectly initialized; please use 'new List()' to create a new list instance.
List<string> data = [];
I wonder about this one - Copilot doesn't seem to know about collection expressions |
It's a known issue with copilot; the model was trained prior to C# 12. |
hopefully the next model will leverage the source code under |
Fixes #59
Replaces #71
cc: @Redth