Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable servers to log to the clients via ILogger #229

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

stephentoub
Copy link
Contributor

Fixes #59
Replaces #71

cc: @Redth

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tests/ModelContextProtocol.Tests/Client/McpClientExtensionsTests.cs:414

  • The list 'data' is incorrectly initialized; please use 'new List()' to create a new list instance.
List<string> data = [];

@Meir017
Copy link

Meir017 commented Apr 7, 2025

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)
tests/ModelContextProtocol.Tests/Client/McpClientExtensionsTests.cs:414

  • The list 'data' is incorrectly initialized; please use 'new List()' to create a new list instance.
List<string> data = [];

I wonder about this one - Copilot doesn't seem to know about collection expressions

@stephentoub
Copy link
Contributor Author

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/ModelContextProtocol.Tests/Client/McpClientExtensionsTests.cs:414

  • The list 'data' is incorrectly initialized; please use 'new List()' to create a new list instance.
List<string> data = [];

I wonder about this one - Copilot doesn't seem to know about collection expressions

It's a known issue with copilot; the model was trained prior to C# 12.

@Meir017
Copy link

Meir017 commented Apr 7, 2025

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/ModelContextProtocol.Tests/Client/McpClientExtensionsTests.cs:414

  • The list 'data' is incorrectly initialized; please use 'new List()' to create a new list instance.
List<string> data = [];

I wonder about this one - Copilot doesn't seem to know about collection expressions

It's a known issue with copilot; the model was trained prior to C# 12.

hopefully the next model will leverage the source code under github.com/dotnet and github.com/azure to learn about new features :)

@stephentoub stephentoub merged commit 3b83ad4 into modelcontextprotocol:main Apr 8, 2025
14 of 15 checks passed
@stephentoub stephentoub deleted the logging branch April 8, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ILogger to be used for sending logs to clients
3 participants