Skip to content

chore: update node driver to 4.0.0-beta.5 MONGOSH-795 #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

rose-m
Copy link
Contributor

@rose-m rose-m commented May 27, 2021

  • Types that are now not visible anymore:
    • Topology - okay, we can just use any
    • ConnectionPool / Connection - okay-ish but bad for our monkey patching type safety
  • Members that are not visible anymore:

@rose-m rose-m self-assigned this May 27, 2021
@rose-m
Copy link
Contributor Author

rose-m commented May 27, 2021

@nbbeeken @emadum In mongodb/node-mongodb-native#2810 you restricted visibility of ClientSession.clusterTime / ClientSession.operationTime to internal. Would it be possible to make them public again? As far as I can see from the official docs (linked above, code sample) they seem to be part of regular API of other drivers.

@rose-m rose-m force-pushed the MONGOSH-795-update-driver branch from aeb100d to bbe0e38 Compare May 27, 2021 09:37
@rose-m rose-m force-pushed the MONGOSH-795-update-driver branch from bbe0e38 to bbd028c Compare May 27, 2021 09:48
@rose-m rose-m merged commit ab925de into main May 27, 2021
@rose-m rose-m deleted the MONGOSH-795-update-driver branch May 27, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants