fix(deps): bump MongoCluster to fix failing test VSCODE-670 #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OIDC tests have been failing on Linux so we are bumping it to the latest version of the OIDC plugin to fix this.
gagik
force-pushed
the
gagik/bump-oidc
branch
from
fa0be8e to
4ac72e9
Compare
gagik
force-pushed
the
gagik/bump-oidc
branch
from
6019e3b to
e92815b
Compare
addaleax
approved these changes
Jan 16, 2025
|
We can do these dependency bumps though doesn't seem like that's the solution, it might be a bug with https://github.com/mongodb-js/devtools-shared/blob/6aa99364c615ab3525af6a1a97b6b00fc551f032/packages/mongodb-runner/src/mongoserver.ts#L220 or our Ubuntu runner where something goes wrong with spawning mongo. |
nirinchev
force-pushed
the
gagik/bump-oidc
branch
from
ec7123d to
d8cbaf2
Compare
nirinchev
approved these changes
Jan 17, 2025
nirinchev
changed the title
nirinchev
reviewed
Jan 17, 2025
| @@ -121,7 +121,7 @@ suite('OIDC Tests', function () { | |||
|
|
|||
| cluster = await MongoCluster.start({ | |||
| ...defaultClusterOptions, | |||
| version: '7.0.x', | |||
| version: '8.0.x', | |||
There was a problem hiding this comment.
This was the actual fix - ubuntu-latest was bumped to 24.04, but 7.0.x only supports up to ubuntu 22, so we have to use a newer server.
gagik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OIDC tests have been failing on Linux so we are bumping it to the latest version of the OIDC plugin to fix this.