This repository was archived by the owner on May 1, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this language might be a little confusing–mongosync itself doesn't balance the source cluster, it's really that the source cluster was balanced prior to mongosync. This might read better if use the language from the jira ticket like "preserve chunk distribution from the source to the destination", because I think what we're really saying is that even if the source is balanced before mongosync, mongosync doesn't guarantee the destination cluster will be balanced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, agree with Nick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distinction we want to draw is, even if the source cluster is itself already properly balanced prior to mongosync being called, this pre-existing balance does not help the destination cluster get balanced because mongosync does not preserve the sharding config