Skip to content

DOCSP-48515-Source-destination-balancing #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025

Conversation

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit d319f05
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67e4168af194200008c266e8
😎 Deploy Preview https://deploy-preview-678--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gmiller-mdb gmiller-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion/question

@mayaraman19 mayaraman19 requested a review from gmiller-mdb March 18, 2025 21:18
Copy link
Collaborator

@gmiller-mdb gmiller-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@nickweinberger nickweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment–curious what Maria thinks since she filed the ticket (cc mvankeulen94)

@@ -113,6 +113,13 @@ destination cluster.
Chunk Distribution
''''''''''''''''''

.. important::

Even if ``mongosync`` balances the source cluster, it does not

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this language might be a little confusing–mongosync itself doesn't balance the source cluster, it's really that the source cluster was balanced prior to mongosync. This might read better if use the language from the jira ticket like "preserve chunk distribution from the source to the destination", because I think what we're really saying is that even if the source is balanced before mongosync, mongosync doesn't guarantee the destination cluster will be balanced.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, agree with Nick

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinction we want to draw is, even if the source cluster is itself already properly balanced prior to mongosync being called, this pre-existing balance does not help the destination cluster get balanced because mongosync does not preserve the sharding config

Copy link

@nickweinberger nickweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM! I left one small suggestion but it's up to you. Thanks for your work on this Maya!

.. important::

Even if the source cluster is balanced, ``mongosync`` does not
ensure balance of the destination cluster. To balance the destination

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Sharding operations are not permitted during the execution of mongosync (see Limitations), you must wait until it is safe to accept writes in order to rebalance the destination cluster. See Sharded Cluster Balancer for guidance on how to rebalance the cluster.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest including the above instead of the sentence "To balance the destination [...]"

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once this last comment is addressed I am good to approve, thanks!

Even if the source cluster is balanced, ``mongosync`` does not
ensure balance of the destination cluster. Because ``mongosync``
does not support the execution of sharding operations during
migration, you must wait until it is safe to accept writes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the link to Limitations from this comment

once that change is added I am good to approve, thank you!

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple non-blocking nits!

@@ -113,6 +113,16 @@ destination cluster.
Chunk Distribution
''''''''''''''''''

.. important::

Even if the source cluster is balanced, ``mongosync`` does not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] We can use contractions in our docs for simplicity!

Suggested change
Even if the source cluster is balanced, ``mongosync`` does not
Even if the source cluster is balanced, ``mongosync`` doesn't

Same goes for the instance below!

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mayaraman19 mayaraman19 merged commit c1b61ee into mongodb:master Mar 26, 2025
4 checks passed
@mayaraman19 mayaraman19 deleted the DOCSP-48515-unbalanced branch March 26, 2025 21:38
@mayaraman19 mayaraman19 changed the title DOCSP-48515: Source/destination balancing DOCSP-48515: Source-destination-balancing Mar 27, 2025
@mayaraman19 mayaraman19 changed the title DOCSP-48515: Source-destination-balancing DOCSP-48515-Source-destination-balancing Mar 27, 2025
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
@mayaraman19
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.11
v1.10
v1.9
v1.8

Questions ?

Please refer to the Backport tool documentation

mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit that referenced this pull request Mar 27, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 31, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
@mayaraman19
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.12

Questions ?

Please refer to the Backport tool documentation

mayaraman19 added a commit that referenced this pull request Mar 31, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 31, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
@mayaraman19
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.13

Questions ?

Please refer to the Backport tool documentation

mayaraman19 added a commit that referenced this pull request Mar 31, 2025
* commit

* feedback

* feedbaclk

* feedback

* feedback

* link

* contractions and ref

(cherry picked from commit c1b61ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants