-
Notifications
You must be signed in to change notification settings - Fork 36
DOCSP-48515-Source-destination-balancing #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mayaraman19
merged 7 commits into
mongodb:master
from
mayaraman19:DOCSP-48515-unbalanced
Mar 26, 2025
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
43225b6
commit
mayaraman19 f3b55a1
feedback
mayaraman19 3a557ed
feedbaclk
mayaraman19 ba56ebb
feedback
mayaraman19 753ac9c
feedback
mayaraman19 f4b7172
link
mayaraman19 d319f05
contractions and ref
mayaraman19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this language might be a little confusing–mongosync itself doesn't balance the source cluster, it's really that the source cluster was balanced prior to mongosync. This might read better if use the language from the jira ticket like "preserve chunk distribution from the source to the destination", because I think what we're really saying is that even if the source is balanced before mongosync, mongosync doesn't guarantee the destination cluster will be balanced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, agree with Nick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distinction we want to draw is, even if the source cluster is itself already properly balanced prior to mongosync being called, this pre-existing balance does not help the destination cluster get balanced because mongosync does not preserve the sharding config