CLOUDP-59516: List available matchers for alerts in the Atlas client #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
requested changes
Mar 23, 2020
mongodbatlas/alert_configurations.go
Outdated
| @@ -17,6 +17,7 @@ type AlertConfigurationsService interface { | |||
| GetAnAlertConfig(context.Context, string, string) (*AlertConfiguration, *Response, error) | |||
| GetOpenAlertsConfig(context.Context, string, string) ([]AlertConfiguration, *Response, error) | |||
| List(context.Context, string, *ListOptions) ([]AlertConfiguration, *Response, error) | |||
| ListMatcherFields(ctx context.Context) (*[]string, *Response, error) | |||
There was a problem hiding this comment.
[nit] I wouldn't go for pointers here
Suggested change
| ListMatcherFields(ctx context.Context) (*[]string, *Response, error) | |
| ListMatcherFields(ctx context.Context) ([]string, *Response, error) |
But if you do it should be []*string
andreaangiolillo
changed the title
gssbzn
approved these changes
Mar 23, 2020
themantissa
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
LGTM! @PacoDw and @marinsalinas can one of you look over this please? It seems to have been missed in the work adding support for alert configurations but assume we didn't need for Terraform, if we do we'll now have it so please keep it in mind?
This was referenced Mar 24, 2020
PacoDw
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CLOUDP-59516(https://jira.mongodb.org/browse/CLOUDP-59516)