Skip to content

CLOUDP-57845: List matcher fields, OM #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 26, 2020
Merged

CLOUDP-57845: List matcher fields, OM #63

merged 10 commits into from
Mar 26, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 23, 2020 •
edited
Loading

Jira ticket: CLOUDP-57845

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli om alerts config fields type

[
	"TYPE_NAME",
	"HOSTNAME",
	"PORT",
	"HOSTNAME_AND_PORT",
	"REPLICA_SET_NAME",
	"SHARD_NAME",
	"CLUSTER_NAME"
]

@andreaangiolillo andreaangiolillo added the waiting_atlas Waiting atlas go client release label Mar 23, 2020
@andreaangiolillo andreaangiolillo requested a review from gssbzn March 23, 2020 19:26
@gssbzn
Copy link
Collaborator

gssbzn commented Mar 24, 2020

waiting on mongodb/go-client-mongodb-atlas#70

@andreaangiolillo andreaangiolillo removed the waiting_atlas Waiting atlas go client release label Mar 25, 2020
gssbzn
gssbzn reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I'm reviewing #62 at the same time, let's either review this after that one is merged or we can just review this one as it's simple enough and close both tickets with this single PR, let me know what you prefer

@andreaangiolillo
Copy link
Collaborator Author

Let's review this one after #62

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 26, 2020 10:14
gssbzn
gssbzn approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 001f5a5 into master Mar 26, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-57845 branch March 26, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn