-
Notifications
You must be signed in to change notification settings - Fork 86
Add a command to list processes #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -31,6 +31,8 @@ func AtlasBuilder() *cobra.Command { | |||
cmd.AddCommand(AtlasBackupsBuilder()) | |||
cmd.AddCommand(AtlasEventsBuilder()) | |||
cmd.AddCommand(AtlasMeasurementsBuilder()) | |||
// cmd.AddCommand(AtlasLogsBuilder()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[np] Can be removed now? Not blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I was working on and could not use as I needed the new format, I'll merge away as the next PR will remove the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as far as I can tell without running it locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm one small question about language
@@ -43,6 +44,8 @@ const ( | |||
DescribeCluster = "Describe a cluster." | |||
ListClusters = "List clusters for a project." | |||
UpdateCluster = "Update a MongoDB cluster in Atlas." | |||
Processes = "Manage processes for your project." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the language here always refer to a project
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This format was done as a favour from the docs team, I'll ask them to give this list of descriptions another go
…ongodb#101) * (DOCSP-28106) Release notes and source constant updates for v1.5.1 * Sets submodule to atlascli/v1.5.1
…ongodb#101) (mongodb#102) * (DOCSP-28106) Release notes and source constant updates for v1.5.1 * Sets submodule to atlascli/v1.5.1
Proposed changes
Looks like atlas changed how we generate the id for the atlas host so I needed this command to get the new id format
Checklist
make fmt
and formatted my codeFurther comments