Skip to content

CLOUDP-57523: Download logs, Atlas #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2020
Merged

CLOUDP-57523: Download logs, Atlas #102

merged 3 commits into from
Apr 15, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Apr 15, 2020

Proposed changes

Jira ticket: CLOUDP-57523

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

mongocli atlas logs download atlas-k11skw-shard-00-02.vnp8x.azure.mongodb-dev.net mongodb.gz -o log.gz

This will download a file so no output

@gssbzn gssbzn requested a review from andreaangiolillo April 15, 2020 17:59
}

func (opts *atlasLogsDownloadOpts) newWriteCloser() (io.WriteCloser, error) {
ff := os.O_CREATE | os.O_TRUNC | os.O_WRONLY | os.O_EXCL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to this as it's a bit mystical

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for adding that comment 😃

@gssbzn gssbzn merged commit f9db3e5 into master Apr 15, 2020
@gssbzn gssbzn deleted the CLOUDP-57523 branch April 15, 2020 18:20
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
…ongodb#101) (mongodb#102)

* (DOCSP-28106) Release notes and source constant updates for v1.5.1

* Sets submodule to atlascli/v1.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants