Skip to content

CLOUDP-57863: List available checkpoints, atlas/cm/om #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 19, 2020
Merged

CLOUDP-57863: List available checkpoints, atlas/cm/om #48

merged 9 commits into from
Mar 19, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Jira ticket: CLOUDP-57863

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested it by using the AWS test environment

@andreaangiolillo andreaangiolillo added waiting_atlas Waiting atlas go client release waiting_ops_manager Waiting ops manager go client release labels Mar 15, 2020
@andreaangiolillo andreaangiolillo requested a review from gssbzn March 15, 2020 13:13
@andreaangiolillo andreaangiolillo removed the waiting_atlas Waiting atlas go client release label Mar 19, 2020
@andreaangiolillo andreaangiolillo removed the waiting_ops_manager Waiting ops manager go client release label Mar 19, 2020
gssbzn
gssbzn requested changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things here, it looks like we are not compliant with the spec, any reason for it?
Also this task should enable this command for CM and OM as it should be the same and it looks like those are missing

gssbzn
gssbzn requested changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things that look like leftovers and we are still missing on adding the command for om and cm

internal/cli/atlas_backups_checkpoints_list.go Outdated
Use: "list",
Aliases: []string{"ls"},
Short: "List continuous backup checkpoints.",
Args: cobra.NoArgs,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to change this or we won't be able to use args for the cluster name/id

internal/cli/atlas_backups_restores_start.go Outdated
@@ -220,7 +220,7 @@ func AtlasBackupsRestoresStartBuilder() *cobra.Command {

cmd.Flags().StringVar(&opts.snapshotID, flags.SnapshotID, "", usage.SnapshotID)
// Atlas uses cluster name
cmd.Flags().StringVar(&opts.clusterName, flags.ClusterName, "", usage.ClusterName)
cmd.Flags().StringVar(&opts.clusterName, flags.ClusterName, "", usage.ClusterNameSnapshots)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rollback this change as well as there's no need for it now?

internal/store/checkpoints.go Outdated
"github.com/mongodb/mongocli/internal/config"
)

type CheckpointsGetter interface {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete this as we don't need it right now? same with the implementation and the store?
They can be implemented later when needed

@andreaangiolillo
Copy link
Collaborator Author

Question about your comment " we are still missing on adding the command for om and cm": the command is inside the AtlasBackupsCheckpointsBuilder, which is inside the AtlasBackupsBuilder which is inside OM, Atlas and CM. So the command should be already inside OM and CM. Am I missing something?

@gssbzn
Copy link
Collaborator

gssbzn commented Mar 19, 2020

@andreaangiolillo my bad with the altas/om/cm stuff, we need to rethink how we organize the commands, this is getting hard

@andreaangiolillo andreaangiolillo requested review from gssbzn and removed request for gssbzn March 19, 2020 15:16
@andreaangiolillo andreaangiolillo added the WIP Work in progress label Mar 19, 2020
gssbzn
gssbzn previously approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work

@andreaangiolillo andreaangiolillo removed the WIP Work in progress label Mar 19, 2020
@andreaangiolillo andreaangiolillo requested a review from gssbzn March 19, 2020 15:21
gssbzn
gssbzn approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the last bit, this looks great

@andreaangiolillo andreaangiolillo merged commit bc55ca2 into master Mar 19, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-57863 branch March 19, 2020 15:22
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
@melissamahoney-mongodb
(DOCSP-23216): v1.1.3 Release Notes & source constant (mongodb#48)
b26ab4b 
* (DOCSP-23216): v1.1.3 Release Notes & source constant

* Set submodule to v1.1.3

* formatting fixes

* copy review
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
@melissamahoney-mongodb
Revert "(DOCSP-23216): v1.1.3 Release Notes & source constant (mongod…
7f372f2 
…b#48)" (mongodb#50)

This reverts commit b26ab4b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn