Skip to content

CLOUDP-57630: C/OM automation status #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Conversation

andreaangiolillo
Copy link
Collaborator

Jira ticket: CLOUDP-57630

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested it using AWS testing environment

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 18, 2020 09:11
gssbzn
gssbzn previously approved these changes Mar 18, 2020
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work

}

type CloudManagerClustersLister interface {
AutomationGetter
AllClusterLister
}

func (s *Store) GetAutomationConfigStatus(projectID string) (*om.AutomationStatus, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be just GetAutomationStatus but not a blocker since there's nothing wrong (that I can see) on this PR 👍

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 1a9e0c6 into master Mar 18, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-57630 branch March 18, 2020 09:38
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants