CLOUDP-57846: List global alerts in mongocli #67
Conversation
| } | ||
|
|
||
| func (opts *opsManagerAlertsGlobalListOpts) Run() error { | ||
| alertOpts := om.AlertsListOptions{ |
There was a problem hiding this comment.
[q] what about pagination?
[nit] you could also do &om.AlertsListOptions{ here and not do the & on line 42
internal/store/global_alerts.go
Outdated
| // GlobalAlerts encapsulate the logic to manage different cloud providers | ||
| func (s *Store) GlobalAlerts(opts *om.AlertsListOptions) (*om.GlobalAlerts, error) { | ||
| switch s.service { | ||
| case config.OpsManagerService, config.CloudManagerService: |
There was a problem hiding this comment.
I think this is config.OpsManagerService only so you may need to remove config.CloudManagerService
| func (opts *opsManagerAlertsGlobalListOpts) Run() error { | ||
| alertOpts := &om.AlertsListOptions{ | ||
| Status: opts.status, | ||
| ListOptions: mongodbatlas.ListOptions{ |
There was a problem hiding this comment.
just as FYI (no need for any change here) you can also do
alertOpts := &om.AlertsListOptions{}
alertOpts.PageNum = opts.pageNumgo has automatic delegation for embedded structs, this is just style and there's no advantage of one over the other, so just letting you know
There was a problem hiding this comment.
Also for future work, we should do with pagination what we did with delete that we embed a struct with the common things that all paginated resources do
There was a problem hiding this comment.
I will create the activity on Jira
DOCSP-24941 Add support for Chocholatey to the installation options
Jira ticket: CLOUDP-57846
Checklist
make fmtand formatted my codeFurther comments
./bin/mongocli om alerts global list --profile OPS{ "links": [ { "rel": "self", "href": "http://localhost:9080/api/public/v1.0/globalAlerts?pageNum=1\u0026itemsPerPage=100" } ], "results": [ { "id": "5e7b354f2e676a3d207a845c", "groupId": "5e7b34822e676a3d207a8399", "alertConfigId": "5e7b35292e676a3d207a8431", "eventTypeName": "USERS_WITHOUT_MULTI_FACTOR_AUTH", "created": "2020-03-25T10:41:19Z", "updated": "2020-03-25T10:53:28Z", "status": "OPEN", "lastNotified": "2020-03-25T10:41:28Z", "acknowledgedUntil": "2020-11-01T03:59:28Z", "acknowledgementComment": "TEST", "acknowledgingUsername": "ydxjuumo", "links": [ { "rel": "self", "href": "http://localhost:9080/api/public/v1.0/globalAlerts/5e7b354f2e676a3d207a845c" } ] } ], "totalCount": 1 }