-
Notifications
You must be signed in to change notification settings - Fork 87
CLOUDP-57846: List global alerts in mongocli #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright 2020 MongoDB Inc | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package cli | ||
|
|
||
| import ( | ||
| "github.com/mongodb/go-client-mongodb-atlas/mongodbatlas" | ||
| om "github.com/mongodb/go-client-mongodb-ops-manager/opsmngr" | ||
| "github.com/mongodb/mongocli/internal/flags" | ||
| "github.com/mongodb/mongocli/internal/json" | ||
| "github.com/mongodb/mongocli/internal/store" | ||
| "github.com/mongodb/mongocli/internal/usage" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| type opsManagerAlertsGlobalListOpts struct { | ||
| store store.GlobalAlertLister | ||
| pageNum int | ||
| itemsPerPage int | ||
| status string | ||
| } | ||
|
|
||
| func (opts *opsManagerAlertsGlobalListOpts) init() error { | ||
| var err error | ||
| opts.store, err = store.New() | ||
| return err | ||
| } | ||
|
|
||
| func (opts *opsManagerAlertsGlobalListOpts) Run() error { | ||
| alertOpts := &om.AlertsListOptions{ | ||
| Status: opts.status, | ||
| ListOptions: mongodbatlas.ListOptions{ | ||
| PageNum: opts.pageNum, | ||
| ItemsPerPage: opts.itemsPerPage, | ||
| }, | ||
| } | ||
|
|
||
| result, err := opts.store.GlobalAlerts(alertOpts) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return json.PrettyPrint(result) | ||
| } | ||
|
|
||
| // mongocli om|cm alert(s) global list [--status status] | ||
| func OpsManagerAlertsGlobalListBuilder() *cobra.Command { | ||
| opts := &opsManagerAlertsGlobalListOpts{} | ||
| cmd := &cobra.Command{ | ||
| Use: "list", | ||
| Short: "List global alerts.", | ||
| Aliases: []string{"ls"}, | ||
| Args: cobra.NoArgs, | ||
| PreRunE: func(cmd *cobra.Command, args []string) error { | ||
| return opts.init() | ||
| }, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return opts.Run() | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().IntVar(&opts.pageNum, flags.Page, 0, usage.Page) | ||
| cmd.Flags().IntVar(&opts.itemsPerPage, flags.Limit, 0, usage.Limit) | ||
| cmd.Flags().StringVar(&opts.status, flags.Status, "", usage.Status) | ||
|
|
||
| return cmd | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright 2020 MongoDB Inc | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package cli | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
| om "github.com/mongodb/go-client-mongodb-ops-manager/opsmngr" | ||
| "github.com/mongodb/mongocli/internal/fixtures" | ||
| "github.com/mongodb/mongocli/internal/mocks" | ||
| ) | ||
|
|
||
| func TestOpsManagerAlertsGlobalList_Run(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| mockStore := mocks.NewMockGlobalAlertLister(ctrl) | ||
|
|
||
| defer ctrl.Finish() | ||
|
|
||
| expected := fixtures.GlobalAlerts() | ||
|
|
||
| alertOpts := om.AlertsListOptions{ | ||
| Status: "OPEN", | ||
| } | ||
|
|
||
| mockStore. | ||
| EXPECT().GlobalAlerts(&alertOpts). | ||
| Return(expected, nil). | ||
| Times(1) | ||
|
|
||
| opts := &opsManagerAlertsGlobalListOpts{ | ||
| store: mockStore, | ||
| status: "OPEN", | ||
| } | ||
|
|
||
| err := opts.Run() | ||
| if err != nil { | ||
| t.Fatalf("Run() unexpected error: %v", err) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright 2020 MongoDB Inc | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package cli | ||
|
|
||
| import ( | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func OpsManagerGlobalBuilder() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "global", | ||
| Short: "Manage Ops Manager global properties.", | ||
| } | ||
|
|
||
| cmd.AddCommand(OpsManagerAlertsGlobalListBuilder()) | ||
| return cmd | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package fixtures | ||
|
|
||
| import ( | ||
| atlas "github.com/mongodb/go-client-mongodb-atlas/mongodbatlas" | ||
| om "github.com/mongodb/go-client-mongodb-ops-manager/opsmngr" | ||
| ) | ||
|
|
||
| func GlobalAlert() *om.GlobalAlert { | ||
| return &om.GlobalAlert{ | ||
| Alert: atlas.Alert{ | ||
| ID: "3b7d2de0a4b02fd2c98146de", | ||
| GroupID: "1", | ||
| AlertConfigID: "5730f5e1e4b030a9634a3f69", | ||
| EventTypeName: "OPLOG_BEHIND", | ||
| Created: "2016-10-09T06:16:36Z", | ||
| Updated: "2016-10-10T22:03:11Z", | ||
| Status: "OPEN", | ||
| LastNotified: "2016-10-10T20:42:32Z", | ||
| ReplicaSetName: "shardedCluster-shard-0", | ||
| ClusterName: "shardedCluster", | ||
| AcknowledgedUntil: "2016-11-01T00:00:00Z", | ||
| AcknowledgingUsername: "[email protected]", | ||
| }, | ||
| Tags: []string{}, | ||
| Links: []*atlas.Link{}, | ||
| SourceTypeName: "REPLICA_SET", | ||
| ClusterID: "572a00f2e4b051814b144e90", | ||
| } | ||
| } | ||
|
|
||
| func GlobalAlerts() *om.GlobalAlerts { | ||
| return &om.GlobalAlerts{ | ||
| Links: []*atlas.Link{}, | ||
| Results: []*om.GlobalAlert{GlobalAlert()}, | ||
| TotalCount: 1, | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| // Copyright 2020 MongoDB Inc | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package store | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| om "github.com/mongodb/go-client-mongodb-ops-manager/opsmngr" | ||
| "github.com/mongodb/mongocli/internal/config" | ||
| ) | ||
|
|
||
| type GlobalAlertLister interface { | ||
| GlobalAlerts(*om.AlertsListOptions) (*om.GlobalAlerts, error) | ||
| } | ||
|
|
||
| type GlobalAlertsStore interface { | ||
| GlobalAlertLister | ||
| } | ||
|
|
||
| // GlobalAlerts encapsulate the logic to manage different cloud providers | ||
| func (s *Store) GlobalAlerts(opts *om.AlertsListOptions) (*om.GlobalAlerts, error) { | ||
| switch s.service { | ||
| case config.OpsManagerService: | ||
| result, _, err := s.client.(*om.Client).GlobalAlerts.List(context.Background(), opts) | ||
| return result, err | ||
| default: | ||
| return nil, fmt.Errorf("unsupported service: %s", s.service) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just as FYI (no need for any change here) you can also do
go has automatic delegation for embedded structs, this is just style and there's no advantage of one over the other, so just letting you know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for future work, we should do with pagination what we did with delete that we embed a struct with the common things that all paginated resources do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create the activity on Jira