Skip to content

test(NODE-3596): update max staleness spec tests #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

test(NODE-3596): update max staleness spec tests #3016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c681e15
test(NODE-3596): update max staleness spec tests
durran Oct 26, 2021
f85c3f4
fix: revert updated test mock
durran Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/functional/unit-sdam/server_selection/spec.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ function collectStalenessTests(specDir) {
return result;
});
});

return tests;
}

Expand Down
6 changes: 3 additions & 3 deletions test/spec/max-staleness/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ Each test specifies that it expects an error, or specifies two sets of servers:
tests pass or fail deterministically.

If the file contains ``error: true``, drivers MUST test that they throw an
error during server selection, due to an invalid read preference or
incompatible wire versions. For other files, drivers MUST test that they
correctly select the set of servers in ``in_latency_window``.
error during server selection due to an invalid read preference. For other
files, drivers MUST test that they correctly select the set of servers in
``in_latency_window``.

Drivers MAY also test that before filtration by latency, they select the
specified set of "suitable" servers.
Expand Down
10 changes: 5 additions & 5 deletions test/spec/max-staleness/ReplicaSetNoPrimary/DefaultNoMaxStaleness.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"type": "RSSecondary",
"avg_rtt_ms": 50,
"lastUpdateTime": 0,
"maxWireVersion": 5,
"maxWireVersion": 6,
"lastWrite": {
"lastWriteDate": {
"$numberLong": "1000001"
Expand All @@ -19,7 +19,7 @@
"type": "RSSecondary",
"avg_rtt_ms": 5,
"lastUpdateTime": 0,
"maxWireVersion": 5,
"maxWireVersion": 6,
"lastWrite": {
"lastWriteDate": {
"$numberLong": "1"
Expand All @@ -37,7 +37,7 @@
"type": "RSSecondary",
"avg_rtt_ms": 50,
"lastUpdateTime": 0,
"maxWireVersion": 5,
"maxWireVersion": 6,
"lastWrite": {
"lastWriteDate": {
"$numberLong": "1000001"
Expand All @@ -49,7 +49,7 @@
"type": "RSSecondary",
"avg_rtt_ms": 5,
"lastUpdateTime": 0,
"maxWireVersion": 5,
"maxWireVersion": 6,
"lastWrite": {
"lastWriteDate": {
"$numberLong": "1"
Expand All @@ -63,7 +63,7 @@
"type": "RSSecondary",
"avg_rtt_ms": 5,
"lastUpdateTime": 0,
"maxWireVersion": 5,
"maxWireVersion": 6,
"lastWrite": {
"lastWriteDate": {
"$numberLong": "1"
Expand Down
4 changes: 2 additions & 2 deletions test/spec/max-staleness/ReplicaSetNoPrimary/DefaultNoMaxStaleness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ topology_description:
type: RSSecondary
avg_rtt_ms: 50 # Too far.
lastUpdateTime: 0
maxWireVersion: 5
maxWireVersion: 6
lastWrite: {lastWriteDate: {$numberLong: "1000001"}}
- &2
address: b:27017
type: RSSecondary
avg_rtt_ms: 5
lastUpdateTime: 0
maxWireVersion: 5
maxWireVersion: 6
lastWrite: {lastWriteDate: {$numberLong: "1"}} # Very stale.
read_preference:
mode: Nearest
Expand Down
36 changes: 0 additions & 36 deletions test/spec/max-staleness/ReplicaSetNoPrimary/Incompatible.json
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions test/spec/max-staleness/ReplicaSetNoPrimary/Incompatible.yml
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions test/spec/max-staleness/ReplicaSetNoPrimary/LastUpdateTime.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "b:27017",
Expand All @@ -25,7 +25,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "c:27017",
Expand All @@ -37,7 +37,7 @@
"$numberLong": "1"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
]
},
Expand All @@ -56,7 +56,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "b:27017",
Expand All @@ -68,7 +68,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
],
"in_latency_window": [
Expand All @@ -82,7 +82,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
]
}
6 changes: 3 additions & 3 deletions test/spec/max-staleness/ReplicaSetNoPrimary/LastUpdateTime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ topology_description:
avg_rtt_ms: 5
lastUpdateTime: 1
lastWrite: {lastWriteDate: {$numberLong: "125002"}}
maxWireVersion: 5
maxWireVersion: 6
- &2
address: b:27017
type: RSSecondary
avg_rtt_ms: 50 # Too far.
lastUpdateTime: 25002 # Not used when there's no primary.
lastWrite: {lastWriteDate: {$numberLong: "2"}} # 125 sec stale + 25 sec heartbeat <= 150 sec maxStaleness.
maxWireVersion: 5
maxWireVersion: 6
- &3
address: c:27017
type: RSSecondary
avg_rtt_ms: 5
lastUpdateTime: 25001
lastWrite: {lastWriteDate: {$numberLong: "1"}} # Too stale.
maxWireVersion: 5
maxWireVersion: 6
read_preference:
mode: Nearest
maxStalenessSeconds: 150
Expand Down
12 changes: 6 additions & 6 deletions test/spec/max-staleness/ReplicaSetNoPrimary/Nearest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "b:27017",
Expand All @@ -25,7 +25,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "c:27017",
Expand All @@ -37,7 +37,7 @@
"$numberLong": "1"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
]
},
Expand All @@ -56,7 +56,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "b:27017",
Expand All @@ -68,7 +68,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
],
"in_latency_window": [
Expand All @@ -82,7 +82,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
]
}
6 changes: 3 additions & 3 deletions test/spec/max-staleness/ReplicaSetNoPrimary/Nearest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ topology_description:
avg_rtt_ms: 5
lastUpdateTime: 0
lastWrite: {lastWriteDate: {$numberLong: "125002"}}
maxWireVersion: 5
maxWireVersion: 6
- &2
address: b:27017
type: RSSecondary
avg_rtt_ms: 50 # Too far.
lastUpdateTime: 0
lastWrite: {lastWriteDate: {$numberLong: "2"}} # 125 sec stale + 25 sec heartbeat <= 150 sec maxStaleness.
maxWireVersion: 5
maxWireVersion: 6
- &3
address: c:27017
avg_rtt_ms: 5
lastUpdateTime: 0
type: RSSecondary
lastWrite: {lastWriteDate: {$numberLong: "1"}} # Too stale.
maxWireVersion: 5
maxWireVersion: 6
read_preference:
mode: Nearest
maxStalenessSeconds: 150
Expand Down
12 changes: 6 additions & 6 deletions test/spec/max-staleness/ReplicaSetNoPrimary/Nearest2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "b:27017",
Expand All @@ -25,7 +25,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "c:27017",
Expand All @@ -37,7 +37,7 @@
"$numberLong": "1"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
]
},
Expand All @@ -56,7 +56,7 @@
"$numberLong": "125002"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
},
{
"address": "b:27017",
Expand All @@ -68,7 +68,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
],
"in_latency_window": [
Expand All @@ -82,7 +82,7 @@
"$numberLong": "2"
}
},
"maxWireVersion": 5
"maxWireVersion": 6
}
]
}
6 changes: 3 additions & 3 deletions test/spec/max-staleness/ReplicaSetNoPrimary/Nearest2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ topology_description:
avg_rtt_ms: 50 # Too far.
lastUpdateTime: 0
lastWrite: {lastWriteDate: {$numberLong: "125002"}}
maxWireVersion: 5
maxWireVersion: 6
- &2
address: b:27017
type: RSSecondary
avg_rtt_ms: 5
lastUpdateTime: 0
lastWrite: {lastWriteDate: {$numberLong: "2"}} # 125 sec stale + 25 sec heartbeat <= 150 sec maxStaleness.
maxWireVersion: 5
maxWireVersion: 6
- &3
address: c:27017
avg_rtt_ms: 5
lastUpdateTime: 0
type: RSSecondary
lastWrite: {lastWriteDate: {$numberLong: "1"}} # Too stale.
maxWireVersion: 5
maxWireVersion: 6
read_preference:
mode: Nearest
maxStalenessSeconds: 150
Expand Down
Loading