chore(NODE-4959): use caret notation for snappy peer dependency #3526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
force-pushed
the
NODE-xxxx-fix-snappy-version-spec
branch
from
15618d2 to
295339b
Compare
baileympearson
added
the
Primary Review
baileympearson
requested changes
Jan 17, 2023
package.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@aws-sdk/credential-providers": "^3.201.0", | |||
| "snappy": "7.x.x", | |||
| "snappy": "^7.2.2", | |||
There was a problem hiding this comment.
If we’re dropping support for snappy <7.2.2 (which I think is okay), let’s document this in our migration guide
There was a problem hiding this comment.
Updated the current section to state it in the title, let me know if we should put more (though we will be revisiting it in the final cleanup ticket)
Also I ran npm install, which sorts the peerdeps and has lock file changes from FLE
baileympearson
approved these changes
Jan 17, 2023
baileympearson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-4959
What is changing?
We decided to use the caret notation instead of .x.x notation in the non-required deps spike
What is the motivation for this change?
Consistency
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript