Skip to content

chore(NODE-4959): use caret notation for snappy peer dependency #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023
Merged

chore(NODE-4959): use caret notation for snappy peer dependency #3526

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
295339b
chore(NODE-xxxx): align snappy peer version spec with other peer deps
nbbeeken Jan 17, 2023
24c430d
update migration, run npm install
nbbeeken Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"peerDependencies": {
"@aws-sdk/credential-providers": "^3.201.0",
"snappy": "7.x.x",
"snappy": "^7.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we’re dropping support for snappy <7.2.2 (which I think is okay), let’s document this in our migration guide

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the current section to state it in the title, let me know if we should put more (though we will be revisiting it in the final cleanup ticket)

Also I ran npm install, which sorts the peerdeps and has lock file changes from FLE

"mongodb-client-encryption": "^2.3.0"
},
"peerDependenciesMeta": {
Expand Down